Bug 188368

<rdar://problem/42987753>

(In reply to Ryosuke Niwa from comment #0) > Now that we have CEReactions=NotNeeded implemented in > https://trac.webkit.org/changeset/234636, > we should mark all relevant IDL attributes, methods, getters, setters, > etc... as such. OK, this is the painful part ;-) For attachment 345839 [details], I checked the idl in the spec one by one and added the extended attributes manually. Maybe we want to do it in a more automated way...

Created attachment 346695 [details] Patch (extracting changes and rebasing attachment 345839 [details])

Comment on attachment 346695 [details] Patch (extracting changes and rebasing attachment 345839 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=346695&action=review > Source/WebCore/html/HTMLElement.idl:65 > [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute boolean autocorrect; We need CEReactions here too for autocorrect content attribute. > Source/WebCore/html/HTMLElement.idl:66 > - [Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize; > + [CEReactions, Conditional=IOS_AUTOCORRECT_AND_AUTOCAPITALIZE] attribute [TreatNullAs=EmptyString] DOMString autocapitalize; We need a test for this. We should probably make this change in a separate patch. > Source/WebCore/html/HTMLInputElement.idl:91 > [Reflect] attribute boolean incremental; We should probably add CEReactions=NotNeeded on apparently non-standard IDL attribute. > Source/WebCore/html/HTMLLinkElement.idl:44 > [Reflect] attribute DOMString nonce; nonce content attribute should have CEReactions=NotNeeded even though the spec doesn't say that: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#nonce-attributes Filed https://github.com/whatwg/html/issues/3887 > Source/WebCore/html/HTMLMediaElement.idl:96 > attribute boolean webkitPreservesPitch; Non-standard mediaGroup below should have CEReactions=NotNeeded as well. > Source/WebCore/html/HTMLPreElement.idl:27 > [Reflect] attribute boolean wrap; Need CEReactions=NotNeeded on this extension. > Source/WebCore/html/HTMLScriptElement.idl:31 > [Reflect] attribute DOMString nonce; We should add CEReactions=NotNeeded here as well. > Source/WebCore/html/HTMLStyleElement.idl:27 > readonly attribute StyleSheet sheet; Ditto about adding CEReactions=NotNeeded to the nonce IDL attribute below. > Source/WebCore/html/HTMLTextAreaElement.idl:39 > + [CEReactions=NotNeeded] attribute [TreatNullAs=EmptyString] DOMString value; This is probably a spec bug: https://github.com/whatwg/html/issues/3889 textarea.value never mutates DOM.

Comment on attachment 346695 [details] Patch (extracting changes and rebasing attachment 345839 [details]) Attachment 346695 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8885960 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

Created attachment 347327 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Created attachment 356119 [details] Updated for trunk

Created attachment 356121 [details] Updated for trunk

I completely forget about this. I can r+ if you need a rubber stamp but maybe someone else should review.

Comment on attachment 356121 [details] Updated for trunk rs=me

Thanks for patch, Frédéric & thanks for the rubber-stamp, Antti!

Committed r238748: <https://trac.webkit.org/changeset/238748>