Bug 183017

Summary: Templatize SVGAnimatedType
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dino, ews-watchlist, jfbastien, simon.fraser, thorton, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183165    
Bug Blocks: 168586    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2018-02-21 14:20:31 PST
This is a code refactoring, It is part of the patch of https://bugs.webkit.org/show_bug.cgi?id=168586. The goal to have SVGAnimatedType be type independent. The appropriate method of this template will be implicitly instantiated based to the type of the animated attribute(s).
Attachments
Patch (118.46 KB, patch)
2018-02-21 14:25 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.32 MB, application/zip)
2018-02-21 16:00 PST, EWS Watchlist 		no flags
Details
Patch (117.30 KB, patch)
2018-03-04 00:21 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (117.30 KB, patch)
2018-03-04 01:17 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (117.30 KB, patch)
2018-03-05 11:29 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2018-02-21 14:25:30 PST
Created attachment 334415 [details] Patch
EWS Watchlist
Comment 2 2018-02-21 16:00:43 PST
Comment on attachment 334415 [details] Patch Attachment 334415 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6615190 New failing tests: svg/text/text-altglyph-01-b.svg svg/W3C-SVG-1.1/text-altglyph-01-b.svg
EWS Watchlist
Comment 3 2018-02-21 16:00:44 PST
Created attachment 334422 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Said Abou-Hallawa
Comment 4 2018-03-04 00:21:29 PST
Created attachment 334977 [details] Patch
Said Abou-Hallawa
Comment 5 2018-03-04 01:17:31 PST
Created attachment 334978 [details] Patch
Said Abou-Hallawa
Comment 6 2018-03-05 11:29:01 PST
Created attachment 335008 [details] Patch
Said Abou-Hallawa
Comment 7 2018-03-06 17:12:08 PST
Can one of the reviewers in the CC list have a look at this bug? Please let me know if a more detailed description of the fix can move this patch forward.
Dean Jackson
Comment 8 2018-03-07 17:37:37 PST
Comment on attachment 335008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335008&action=review > Source/WebCore/svg/SVGAnimatedAngle.cpp:83 > + const auto& fromAngleAndEnumeration = (m_animationElement->animationMode() == ToAnimation ? animated : from)->as<std::pair<SVGAngleValue, unsigned>>(); Given that you have to call this test so often, maybe it could be a helper? m_animationElement->isToAnimation() ? animated : from
Said Abou-Hallawa
Comment 9 2018-03-08 10:27:30 PST
Comment on attachment 335008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335008&action=review >> Source/WebCore/svg/SVGAnimatedAngle.cpp:83 >> + const auto& fromAngleAndEnumeration = (m_animationElement->animationMode() == ToAnimation ? animated : from)->as<std::pair<SVGAngleValue, unsigned>>(); > > Given that you have to call this test so often, maybe it could be a helper? > > m_animationElement->isToAnimation() ? animated : from I will include this change in the next patch.
WebKit Commit Bot
Comment 10 2018-03-08 10:47:51 PST
Comment on attachment 335008 [details] Patch Clearing flags on attachment: 335008 Committed r229417: <https://trac.webkit.org/changeset/229417>
WebKit Commit Bot
Comment 11 2018-03-08 10:47:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-03-08 10:48:25 PST
<rdar://problem/38268664>
Note You need to log in before you can comment on or make changes to this bug.