Bug 182667

Summary: Web Inspector: Canvas tab: tree selection abruptly changes when selecting a recording frame
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175485, 183015    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Matt Baker
Reported 2018-02-09 17:50:35 PST
Summary: Tree selection abruptly changes when selecting a recording frame. Steps to Reproduce: 1. Goto https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations 2. Record any canvas 3. In the sidebar, select 'Frame 1' => Tree selection jumps to the last action in the frame
Attachments
Patch (11.73 KB, patch)
2018-02-09 18:14 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (12.07 KB, patch)
2018-02-09 18:34 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.93 KB, patch)
2018-02-09 21:32 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-09 17:51:06 PST
<rdar://problem/37412639>
Matt Baker
Comment 2 2018-02-09 18:14:44 PST
Created attachment 333545 [details] Patch
Matt Baker
Comment 3 2018-02-09 18:34:07 PST
Created attachment 333548 [details] Patch
Devin Rousso
Comment 4 2018-02-09 19:10:26 PST
Comment on attachment 333548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333548&action=review r=me. This feels much more smooth. I still think that we shouldn't auto-select a recording when viewing a Canvas, but we can discuss that before doing anything. > Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css:71 > +.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .status { > + line-height: 16px; > +} This rule already exists below. > Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:247 > +.tree-outline:not(.large):matches(:focus, .force-focus) .item.selected .status .indeterminate-progress-spinner { > + filter: invert(); > +} Nice!
Matt Baker
Comment 5 2018-02-09 21:32:57 PST
Created attachment 333552 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-02-09 22:15:51 PST
Comment on attachment 333552 [details] Patch for landing Clearing flags on attachment: 333552 Committed r228362: <https://trac.webkit.org/changeset/228362>
WebKit Commit Bot
Comment 7 2018-02-09 22:15:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.