Bug 180290

Summary:

[css-grid] Rename gutter properties to remove "grid-" prefix

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

Layout and Rendering

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, jfernandez, rego, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=761904

Bug Depends on:

182004

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews116 for mac-sierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews102 for mac-sierra	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Patch	none
Patch	none
Patch for landing	none

Javier Fernandez

Reported 2017-12-01 15:29:19 PST

The CSS WG has resolved to rename the gap properties: * grid-column-gap to column-gap * grid-row-gap to row-gap * grid-gap to gap Note that the default value is "normal" instead of "0". Probably we need to keep the prefixed versions for a while (or forever) working as an alias of the new ones. The new ones will eventually apply to Flexbox too.

Attachments
Patch (34.00 KB, patch) 2018-01-30 14:42 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.58 MB, application/zip) 2018-01-30 17:04 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.14 MB, application/zip) 2018-01-30 17:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.25 MB, application/zip) 2018-01-30 17:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews102 for mac-sierra (2.58 MB, application/zip) 2018-01-30 17:44 PST, EWS Watchlist	no flags	Details
Patch (35.54 KB, patch) 2018-01-31 03:44 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (167.35 KB, patch) 2018-02-05 02:35 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (739.47 KB, application/zip) 2018-02-05 03:27 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (860.79 KB, application/zip) 2018-02-05 03:30 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (715.80 KB, application/zip) 2018-02-05 03:42 PST, EWS Watchlist	no flags	Details
Patch (121.38 KB, patch) 2018-02-05 03:47 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (121.27 KB, patch) 2018-02-05 03:54 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch for landing (121.20 KB, patch) 2018-02-05 04:51 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2017-12-01 15:29:29 PST

Link to the CSS WG GitHub issue: https://github.com/w3c/csswg-drafts/issues/1696 And the commit introducing the change on the spec: https://github.com/w3c/csswg-drafts/commit/8f243616df9b967ae546459e955ce0186188b54b

Manuel Rego Casasnovas

Comment 2 2018-01-30 14:42:55 PST

Created attachment 332710 [details] Patch Not ready for review yet as it needs to import several WPT tests that will land with the Blink patch.

EWS Watchlist

Comment 3 2018-01-30 16:45:30 PST

Attachment 332710 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:22: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2018-01-30 17:04:40 PST

Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6269300 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html

EWS Watchlist

Comment 5 2018-01-30 17:04:41 PST

Created attachment 332727 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-01-30 17:08:08 PST

Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6268749 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html

EWS Watchlist

Comment 7 2018-01-30 17:08:09 PST

Created attachment 332728 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-01-30 17:08:39 PST

Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6268873 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html

EWS Watchlist

Comment 9 2018-01-30 17:08:40 PST

Created attachment 332729 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-01-30 17:43:58 PST

Comment on attachment 332710 [details] Patch Attachment 332710 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6270998 New failing tests: fast/css-grid-layout/grid-shorthand-get-set.html

EWS Watchlist

Comment 11 2018-01-30 17:44:00 PST

Created attachment 332732 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

Manuel Rego Casasnovas

Comment 12 2018-01-31 03:44:33 PST

Created attachment 332755 [details] Patch

EWS Watchlist

Comment 13 2018-01-31 03:47:16 PST

Attachment 332755 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:22: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Manuel Rego Casasnovas

Comment 14 2018-02-05 02:35:08 PST

Created attachment 333067 [details] Patch Patch ready for review, including the WPT tests.

EWS Watchlist

Comment 15 2018-02-05 03:27:38 PST

Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6363080 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 16 2018-02-05 03:27:39 PST

Created attachment 333068 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 17 2018-02-05 03:30:31 PST

Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6363085 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 18 2018-02-05 03:30:33 PST

Created attachment 333069 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 19 2018-02-05 03:42:01 PST

Comment on attachment 333067 [details] Patch Attachment 333067 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6363088 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 20 2018-02-05 03:42:02 PST

Created attachment 333070 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Manuel Rego Casasnovas

Comment 21 2018-02-05 03:47:38 PST

Created attachment 333071 [details] Patch

Manuel Rego Casasnovas

Comment 22 2018-02-05 03:54:35 PST

Created attachment 333072 [details] Patch

Javier Fernandez

Comment 23 2018-02-05 04:26:54 PST

Comment on attachment 333072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333072&action=review > Source/WebCore/ChangeLog:8 > + [css-grid] Rename gutter properties to remove "grid-" prefix This line looks like duplicated, please delete it.

Manuel Rego Casasnovas

Comment 24 2018-02-05 04:51:11 PST

Created attachment 333075 [details] Patch for landing

Manuel Rego Casasnovas

Comment 25 2018-02-05 04:51:36 PST

Comment on attachment 333072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333072&action=review Thanks for the review. >> Source/WebCore/ChangeLog:8 >> + [css-grid] Rename gutter properties to remove "grid-" prefix > > This line looks like duplicated, please delete it. Done.

WebKit Commit Bot

Comment 26 2018-02-05 05:38:56 PST

The commit-queue encountered the following flaky tests while processing attachment 333075 [details]: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html bug 169158 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 27 2018-02-05 05:39:01 PST

The commit-queue encountered the following flaky tests while processing attachment 333075 [details]: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html bug 182481 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 28 2018-02-05 05:51:30 PST

Comment on attachment 333075 [details] Patch for landing Clearing flags on attachment: 333075 Committed r228095: <https://trac.webkit.org/changeset/228095>

WebKit Commit Bot

Comment 29 2018-02-05 05:51:32 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2018-02-05 05:53:36 PST

<rdar://problem/37233873>

Note You need to log in before you can comment on or make changes to this bug.