Bug 179474

Summary:

[WinCairo] Add network (curl) files for wincairo webkit

Product:

WebKit

Reporter:

Yousuke Kimoto <Yousuke.Kimoto>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, commit-queue, don.olmstead, ews-watchlist, pvollan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

174003

Attachments:

Description	Flags
[PATCH] Add network (curl) files for WinCairo WebKit	achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Rebased	none
Rebased	none
[PATCH] Add network (curl) files for wincairo webkit	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
[PATCH] Add network (curl) files for wincairo webkit	none

Yousuke Kimoto

Reported 2017-11-09 04:54:42 PST

Add network files related to curl for wincairo webkit.

Attachments
[PATCH] Add network (curl) files for WinCairo WebKit (22.54 KB, patch) 2017-11-13 21:44 PST, Yousuke Kimoto	achristensen: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.13 MB, application/zip) 2017-11-13 23:08 PST, Build Bot	no flags	Details
Rebased (12.90 KB, patch) 2017-11-14 15:00 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Rebased (12.90 KB, patch) 2017-11-14 15:09 PST, Don Olmstead	no flags	Details Formatted Diff Diff
[PATCH] Add network (curl) files for wincairo webkit (24.68 KB, patch) 2017-11-16 18:21 PST, Yousuke Kimoto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.56 MB, application/zip) 2017-11-16 19:16 PST, EWS Watchlist	no flags	Details
[PATCH] Add network (curl) files for wincairo webkit (24.68 KB, patch) 2017-11-16 19:51 PST, Yousuke Kimoto	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Yousuke Kimoto

Comment 1 2017-11-13 21:44:54 PST

Created attachment 326853 [details] [PATCH] Add network (curl) files for WinCairo WebKit

Build Bot

Comment 2 2017-11-13 23:08:18 PST

Comment on attachment 326853 [details] [PATCH] Add network (curl) files for WinCairo WebKit Attachment 326853 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5224256 New failing tests: http/tests/workers/service/service-worker-clear.html

Build Bot

Comment 3 2017-11-13 23:08:19 PST

Created attachment 326862 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Don Olmstead

Comment 4 2017-11-14 11:17:33 PST

WinCairo EWS is failing because of r224791 but other than that it should be okay to review. Not sure what's up with ios-sim as this patch has no ios modifications.

Alex Christensen

Comment 5 2017-11-14 13:35:38 PST

Comment on attachment 326853 [details] [PATCH] Add network (curl) files for WinCairo WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=326853&action=review > Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69 > +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&) This will need rebasing after https://trac.webkit.org/changeset/224791/webkit

Don Olmstead

Comment 6 2017-11-14 15:00:50 PST

Created attachment 326929 [details] Rebased Rebasing patch

Don Olmstead

Comment 7 2017-11-14 15:09:18 PST

Created attachment 326931 [details] Rebased

Yousuke Kimoto

Comment 8 2017-11-14 19:50:05 PST

(In reply to Alex Christensen from comment #5) > Comment on attachment 326853 [details] > [PATCH] Add network (curl) files for WinCairo WebKit > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326853&action=review > > > Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69 > > +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&) > > This will need rebasing after https://trac.webkit.org/changeset/224791/webkit ensurePrivateBrowsingSession() must be removed from attachment 326853 [details], I'll do that.

Yousuke Kimoto

Comment 9 2017-11-16 18:21:29 PST

Created attachment 327141 [details] [PATCH] Add network (curl) files for wincairo webkit

EWS Watchlist

Comment 10 2017-11-16 19:16:21 PST

Comment on attachment 327141 [details] [PATCH] Add network (curl) files for wincairo webkit Attachment 327141 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5267705 New failing tests: http/tests/appcache/offline-access.html

EWS Watchlist

Comment 11 2017-11-16 19:16:22 PST

Created attachment 327144 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Yousuke Kimoto

Comment 12 2017-11-16 19:51:09 PST

Created attachment 327145 [details] [PATCH] Add network (curl) files for wincairo webkit Just updated reviewer's line.

WebKit Commit Bot

Comment 13 2017-11-16 22:14:31 PST

Comment on attachment 327145 [details] [PATCH] Add network (curl) files for wincairo webkit Clearing flags on attachment: 327145 Committed r224961: <https://trac.webkit.org/changeset/224961>

WebKit Commit Bot

Comment 14 2017-11-16 22:14:33 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2017-11-16 22:15:34 PST

<rdar://problem/35608759>

Note You need to log in before you can comment on or make changes to this bug.