Bug 17806

Summary: Arena.h's CLEAR_UNUSED should use statement1;statement2 instead of (statement1,statement2)
Product: WebKit Reporter: Mark Mentovai <mark>
Component: PlatformAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Fix eric: review+

Mark Mentovai
Reported 2008-03-12 14:04:21 PDT
I don't think this (statement1,statement2) thing is necessary, and it's causing trouble for me in a build with DEBUG defined. As far as I'm aware, the only use of CLEAR_UNUSED is in Arena.cpp.
Attachments
Fix (1.20 KB, patch)
2008-03-12 14:05 PDT, Mark Mentovai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Mentovai
Comment 1 2008-03-12 14:05:06 PDT
Created attachment 19710 [details] Fix
Eric Seidel (no email)
Comment 2 2008-03-12 14:17:41 PDT
Comment on attachment 19710 [details] Fix I don't understand why your compiler would barf here. Or why our build doesn't barf. But the change looks sane. r=me.
Eric Seidel (no email)
Comment 3 2008-03-13 20:45:45 PDT
Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053
Note You need to log in before you can comment on or make changes to this bug.