Bug 177287

Summary: Web Inspector: Remove support for CSS Regions
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, commit-queue, hyatt, inspector-bugzilla-changes, joepeck, keith_miller, koivisto, mark.lam, mattbaker, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=177249
Bug Depends on:    
Bug Blocks: 174978    
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-09-20 18:56:31 PDT
Remove support for CSS Regions. Part of the overall: <https://webkit.org/b/174978> Remove support for CSS regions CSS Domain: "id": "Region", "id": "NamedFlow", "name": "getNamedFlowCollection", "namedFlowCreated", "namedFlowRemoved", "regionOversetChanged", "registeredNamedFlowContentElement", "unregisteredNamedFlowContentElement", And related Frontend handling of Regions. Note: - We MUST leave in the observer points at the least. - Maybe leave stuff in so older backends still have something to show? Probably not though.
Attachments
[PATCH] Proposed Fix (103.87 KB, patch)
2017-09-21 13:24 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (105.68 KB, patch)
2017-09-21 13:31 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-21 11:49:25 PDT
As others have pointed out, we should remove associated tests as well.
Joseph Pecoraro
Comment 2 2017-09-21 13:24:59 PDT
Created attachment 321471 [details] [PATCH] Proposed Fix
Build Bot
Comment 3 2017-09-21 13:27:58 PDT
Attachment 321471 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1506: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1778: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1779: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1780: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1781: Path does not exist. [test/expectations] [5] Total errors found: 5 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2017-09-21 13:31:47 PDT
Created attachment 321472 [details] [PATCH] Proposed Fix
Matt Baker
Comment 5 2017-09-21 14:09:47 PDT
Comment on attachment 321472 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 6 2017-09-21 15:32:53 PDT
Comment on attachment 321472 [details] [PATCH] Proposed Fix Clearing flags on attachment: 321472 Committed r222356: <http://trac.webkit.org/changeset/222356>
WebKit Commit Bot
Comment 7 2017-09-21 15:32:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:19:19 PDT
<rdar://problem/34693031>
Note You need to log in before you can comment on or make changes to this bug.