Bug 175756

Summary: Simplify calls to LoaderStrategy::startPingLoad()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dbates, esprehn+autocc, ggaren, japhet, kangil.han, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175746    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-08-20 11:03:40 PDT
Simplify calls to LoaderStrategy::startPingLoad().
Attachments
Patch (16.07 KB, patch)
2017-08-20 13:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-08-20 13:40:04 PDT
Created attachment 318605 [details] Patch
WebKit Commit Bot
Comment 2 2017-08-20 16:11:44 PDT
Comment on attachment 318605 [details] Patch Clearing flags on attachment: 318605 Committed r220957: <http://trac.webkit.org/changeset/220957>
WebKit Commit Bot
Comment 3 2017-08-20 16:11:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-08-20 16:12:19 PDT
<rdar://problem/33984511>
youenn fablet
Comment 5 2017-08-20 18:39:40 PDT
Comment on attachment 318605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318605&action=review > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:425 > + loadParameters.sourceOrigin = &document->securityOrigin(); Since we have both request and sourceOrigin, I wonder whether we should not add an ASSERT ensuring that the Origin header of the request, if any, is matching sourceOrigin. And maybe one for referer as well. > Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:432 > + if (auto * contentSecurityPolicy = document->contentSecurityPolicy()) space between auto and *.
Note You need to log in before you can comment on or make changes to this bug.