Bug 175032

Summary: Highlight for search match in overflow node is not properly scrolled
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dvoytenko, malte, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 11   
Attachments:
Description Flags
testcase
none
testcase
none
Patch none

Frédéric Wang (:fredw)
Reported 2017-08-01 09:49:02 PDT
Created attachment 316865 [details] testcase Use "Find in page" in that text case to search "text" and highlight the single search match. Then scroll the overflow node: The highlighted text does not moved with the content of the overflow node. Extracting this from bug 163911, as that seems orthogonal.
Attachments
testcase (813 bytes, text/html)
2017-08-01 09:49 PDT, Frédéric Wang (:fredw) 		no flags
Details
testcase (1.10 KB, text/html)
2018-03-13 04:56 PDT, Frédéric Wang (:fredw) 		no flags
Details
Patch (10.15 KB, patch)
2019-06-28 17:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-03-13 04:56:47 PDT
Created attachment 335689 [details] testcase This is an extended testcase, showing that dynamic scrolls of the main frame or of the subframe make the selection disappear (contrary to desktop). So to summarize: - User scroll of a the main frame with hightlighted text works. - User scroll of a subframe with hightlighted text does not update the position of the highlighted text. - Programmatic scroll of the main frame or a subframe with hightlighted text makes the selection disappear.
Tim Horton
Comment 2 2019-06-28 17:14:01 PDT
Created attachment 373166 [details] Patch
WebKit Commit Bot
Comment 3 2019-06-28 20:48:24 PDT
Comment on attachment 373166 [details] Patch Clearing flags on attachment: 373166 Committed r246948: <https://trac.webkit.org/changeset/246948>
WebKit Commit Bot
Comment 4 2019-06-28 20:48:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-06-28 20:49:17 PDT
<rdar://problem/52369021>
Note You need to log in before you can comment on or make changes to this bug.