Bug 173964

Summary: [Curl] Implement missing async method in RecourceHandle and make it actually async
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, buildbot, commit-queue, don.olmstead, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173630, 174654, 175148    
Bug Blocks: 117300, 160677, 174003    
Attachments:
Description Flags
patch
achristensen: review+, commit-queue: commit-queue-
fix
none
fix none

Basuke Suzuki
Reported 2017-06-28 23:17:28 PDT
Use asynchronous ResourceHandleClient calls for WebKit1 and implement missing methods for ResourceHandle
Attachments
patch (17.02 KB, patch)
2017-10-02 12:31 PDT, Basuke Suzuki 		achristensen: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
fix (20.03 KB, patch)
2017-10-02 14:05 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix (20.01 KB, patch)
2017-10-02 14:14 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-10-02 12:31:11 PDT
Created attachment 322410 [details] patch
WebKit Commit Bot
Comment 2 2017-10-02 13:30:18 PDT
Comment on attachment 322410 [details] patch Rejecting attachment 322410 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 322410, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 222737 = 55509b4cac458e9f12cbb2726b3f94d80c2186aa r222738 = 88455e7cce3ce6b46612247f596e80c392194816 r222739 = 407dc92015b4c80f27258f4d9ec449e1b06b1833 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4728227
Basuke Suzuki
Comment 3 2017-10-02 14:05:40 PDT
Created attachment 322434 [details] fix Forget to include ChangeLog.
Basuke Suzuki
Comment 4 2017-10-02 14:14:50 PDT
Created attachment 322435 [details] fix
WebKit Commit Bot
Comment 5 2017-10-02 16:34:22 PDT
Comment on attachment 322435 [details] fix Clearing flags on attachment: 322435 Committed r222756: <http://trac.webkit.org/changeset/222756>
WebKit Commit Bot
Comment 6 2017-10-02 16:34:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-02 16:35:37 PDT
<rdar://problem/34780283>
Note You need to log in before you can comment on or make changes to this bug.