Bug 173557

Summary: [Curl] Extract CurlDownloadManager as shared background task handler
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, buildbot, cdumez, don.olmstead, fujii.hironori, joepeck, ossy, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300, 173629    
Attachments:
Description Flags
Patch
none
Fix
none
Patch
none
Fix build error joepeck: review+

Basuke Suzuki
Reported 2017-06-19 11:34:34 PDT
The CurlDownload implementation includes CurlDownloadManager as a companion class for multiple download management. The class can be used from resource handle, so it should be separated from CurlDownload and to be prepare for further usage.
Attachments
Patch (37.75 KB, patch)
2017-06-19 15:17 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Fix (34.99 KB, patch)
2017-06-20 09:39 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (34.68 KB, patch)
2017-06-21 09:48 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Fix build error (1.10 KB, patch)
2017-06-22 13:26 PDT, Basuke Suzuki 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-06-19 15:17:17 PDT
Created attachment 313335 [details] Patch
Build Bot
Comment 2 2017-06-19 15:18:46 PDT
Attachment 313335 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:86: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/platform/network/curl/CookieJarCurl.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Basuke Suzuki
Comment 4 2017-06-19 15:28:03 PDT
I didn't fix this style error because I've just change the header list on that file.
Basuke Suzuki
Comment 5 2017-06-20 09:39:51 PDT
Created attachment 313408 [details] Fix Remove duplicated ChangeLog Borrowed copyright from sibling source file Remove unused interface.
Alex Christensen
Comment 6 2017-06-21 09:46:26 PDT
Comment on attachment 313408 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=313408&action=review > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:252 > + CURLSH* curlsh = CurlManager::shared().getCurlShareHandle(); We usually use "singleton" in WebKit instead of "shared"
Alex Christensen
Comment 7 2017-06-21 09:48:30 PDT
Created attachment 313524 [details] Patch
Alex Christensen
Comment 8 2017-06-21 09:49:07 PDT
http://trac.webkit.org/r218637
Csaba Osztrogonác
Comment 9 2017-06-22 04:48:27 PDT
(In reply to Alex Christensen from comment #8) > http://trac.webkit.org/r218637 FYI, it broke the WinCairo build: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/3606
Basuke Suzuki
Comment 10 2017-06-22 08:40:44 PDT
Oh, thank you. I am fixing this problem.
Basuke Suzuki
Comment 11 2017-06-22 13:26:54 PDT
Created attachment 313653 [details] Fix build error This fix is to solve WinCairo build error.
Basuke Suzuki
Comment 12 2017-06-22 13:29:00 PDT
The previous patch broke the wincairo build.
Joseph Pecoraro
Comment 13 2017-06-22 13:54:22 PDT
Comment on attachment 313653 [details] Fix build error rs=me, but it would be good to describe how this solves the issue in the ChangeLog. I guess curl.h is smarter about checking if SOCKET is defined already? To avoid the redefinition error: C:\Program Files (x86)\Windows Kits\8.1\include\um\winsock2.h(111): error C2371: 'SOCKET': redefinition; different basic types
Basuke Suzuki
Comment 14 2017-06-22 14:06:15 PDT
I thought so and I can see the ifdef check inside curl/curl.h, but cannot solve this moment. I will keep refactoring this part and will see what's going on by following patches. I am so sorry about breaking the WinCairo build at this moment, so I hope this patch will be landed quickly.
Alex Christensen
Comment 15 2017-06-23 10:55:35 PDT
If this fixes the build, we need the build fixed. We can't just have the build broken for many days at a time just because we're thinking about why a build fix works. If we need to improve it in the future, we will. http://trac.webkit.org/r218752
Basuke Suzuki
Comment 16 2017-06-23 11:38:52 PDT
Thanks, Alex.
Note You need to log in before you can comment on or make changes to this bug.