Bug 173019

Summary: Update to slightly stricter rules for custom element names from more recent standard draft
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Patch
none
Patch
none
Patch rniwa: review+

Darin Adler
Reported 2017-06-06 11:27:51 PDT
Update to slightly stricter rules for custom element names from more recent standard draft
Attachments
Patch (9.62 KB, patch)
2017-06-06 11:34 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (9.68 KB, patch)
2017-06-06 12:10 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (12.52 KB, patch)
2017-06-06 12:58 PDT, Darin Adler 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-06-06 11:34:25 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2017-06-06 11:34:54 PDT
Test coverage is not great.
Darin Adler
Comment 3 2017-06-06 12:10:46 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2017-06-06 12:58:29 PDT
Created attachment 312109 [details] Patch
Darin Adler
Comment 5 2017-06-06 14:09:26 PDT
All the tests passed so now it’s definitely ready for review.
Ryosuke Niwa
Comment 6 2017-06-06 15:21:26 PDT
Comment on attachment 312109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312109&action=review > Source/WebCore/dom/Document.cpp:1065 > +// https://www.w3.org/TR/custom-elements/#valid-custom-element-name Please use https://html.spec.whatwg.org/#valid-custom-element-name instead since that's spec is obsolete.
Ryosuke Niwa
Comment 7 2017-06-06 15:21:57 PDT
Nice fix!
Radar WebKit Bug Importer
Comment 8 2017-06-06 15:22:11 PDT
<rdar://problem/32599604>
Darin Adler
Comment 9 2017-06-06 15:38:31 PDT
Committed r217864: <http://trac.webkit.org/changeset/217864>
Note You need to log in before you can comment on or make changes to this bug.