Bug 171325

Summary: Speedometer: Add a Vue.js TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, banti17997, buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch none

Addy Osmani
Reported 2017-04-26 08:49:08 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this would add Vue.js, another popular JavaScript framework for building desktop and mobile web applications to the benchmark.
Attachments
Patch (279.87 KB, patch)
2017-04-26 08:51 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (268.80 KB, patch)
2017-05-11 17:32 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-26 08:51:04 PDT
Created attachment 308252 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-09 14:30:53 PDT
Comment on attachment 308252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308252&action=review > PerformanceTests/ChangeLog:7 > + Adds a Vue.js TodoMVC implementation to Speedometer Ditto a blank line before this. > PerformanceTests/ChangeLog:9 > + * Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.babelrc: Added. Do we really need to include these configuration files? > PerformanceTests/ChangeLog:19 > + (body,button,html): Ditto remove these comments.
Addy Osmani
Comment 3 2017-05-11 17:32:14 PDT
Created attachment 309833 [details] Patch
Addy Osmani
Comment 4 2017-05-11 17:33:19 PDT
Added a blank line above the CL title. The config files are needed for the app to build if we need to change it/fix any bugs in future. Removed the additional comments requested. PTAL.
Ryosuke Niwa
Comment 5 2017-05-11 19:54:32 PDT
Comment on attachment 309833 [details] Patch Clearing flags on attachment: 309833 Committed r216720: <http://trac.webkit.org/changeset/216720>
Ryosuke Niwa
Comment 6 2017-05-11 19:54:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.