Bug 170764

Summary:

[css-grid] Add support for percentage gaps

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Layout and Rendering

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, jfernandez, rniwa, simon.fraser, svillar, zalan

Priority:

Keywords:

BlinkMergeCandidate

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=615248

Bug Depends on:

168657

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	none
Mini change on ChangeLog	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch for landing	none

Manuel Rego Casasnovas

Reported 2017-04-11 22:45:10 PDT

This has been already implemented in Blink. Part of the code related to this was already imported into WebKit in bug #168657 but never used yet as the parsing was disabled. We should enable the use of percentages in parsing and then import the tests from Blink related to this.

Attachments
Patch (37.48 KB, patch) 2017-04-11 22:58 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Mini change on ChangeLog (37.49 KB, patch) 2017-04-12 01:40 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (885.64 KB, application/zip) 2017-04-12 02:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (865.02 KB, application/zip) 2017-04-12 04:00 PDT, Build Bot	no flags	Details
Patch for landing (37.15 KB, patch) 2017-04-18 08:42 PDT, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2017-04-11 22:58:37 PDT

Created attachment 306891 [details] Patch

Manuel Rego Casasnovas

Comment 2 2017-04-12 01:40:19 PDT

Created attachment 306897 [details] Mini change on ChangeLog

Build Bot

Comment 3 2017-04-12 02:45:57 PDT

Comment on attachment 306897 [details] Mini change on ChangeLog Attachment 306897 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3522867 New failing tests: webrtc/negotiatedneeded-event-addStream.html

Build Bot

Comment 4 2017-04-12 02:45:58 PDT

Created attachment 306901 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-04-12 04:00:29 PDT

Comment on attachment 306897 [details] Mini change on ChangeLog Attachment 306897 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3522979 New failing tests: compositing/absolute-inside-out-of-view-fixed.html

Build Bot

Comment 6 2017-04-12 04:00:30 PDT

Created attachment 306906 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Sergio Villar Senin

Comment 7 2017-04-18 07:43:00 PDT

Comment on attachment 306897 [details] Mini change on ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review > LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15 > +.rows50-50 { grid-template-rows: 50px 50px; } We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that. > LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33 > +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; } Seems unrelated? > LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:44 > +.gridInvalidImplicitGridGap { grid-gap: -webkit-fit-content; } Ditto.

Manuel Rego Casasnovas

Comment 8 2017-04-18 08:42:55 PDT

Created attachment 307385 [details] Patch for landing

Manuel Rego Casasnovas

Comment 9 2017-04-18 08:45:33 PDT

Comment on attachment 306897 [details] Mini change on ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review Thanks for the review. >> LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15 >> +.rows50-50 { grid-template-rows: 50px 50px; } > > We haven't used this kind of notation %d-%d for class names in the past. We normally do things like two100Column or things like that. Ok, changed that. >> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33 >> +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; } > > Seems unrelated? Indeed, a copy&paste issue. :-)

WebKit Commit Bot

Comment 10 2017-04-18 09:27:56 PDT

Comment on attachment 307385 [details] Patch for landing Clearing flags on attachment: 307385 Committed r215463: <http://trac.webkit.org/changeset/215463>

WebKit Commit Bot

Comment 11 2017-04-18 09:27:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.