Bug 169270

Summary: [css-grid] Mark a few tests from the W3C suite as pass after r213480
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, hyatt, jfernandez, lforschler, rniwa, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Patch none

Manuel Rego Casasnovas
Reported 2017-03-07 03:30:09 PST
r213480 was porting some Blink patches that makes these tests to pass now. Check the following bugs for more information: - https://bugs.webkit.org/show_bug.cgi?id=169197 - https://bugs.webkit.org/show_bug.cgi?id=169198
Attachments
Patch (2.13 KB, patch)
2017-03-07 03:31 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (1011.76 KB, application/zip)
2017-03-07 04:34 PST, Build Bot 		no flags
Details
Patch (2.45 KB, patch)
2017-03-07 04:36 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2017-03-07 03:31:11 PST
Created attachment 303639 [details] Patch
Build Bot
Comment 2 2017-03-07 04:34:21 PST
Comment on attachment 303639 [details] Patch Attachment 303639 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3258343 New failing tests: imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html
Build Bot
Comment 3 2017-03-07 04:34:25 PST
Created attachment 303642 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Manuel Rego Casasnovas
Comment 4 2017-03-07 04:36:13 PST
Created attachment 303643 [details] Patch
Manuel Rego Casasnovas
Comment 5 2017-03-07 04:37:18 PST
Comment on attachment 303643 [details] Patch imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html was still failing, but not for a different problem (see bug #169271).
Manuel Rego Casasnovas
Comment 6 2017-03-07 05:02:35 PST
(In reply to comment #5) > Comment on attachment 303643 [details] > Patch > > > imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment- > 001.html was still failing, but not for a different problem (see bug > #169271). There's a typo in the previous sentence: "but NOW for a different problem (see bug #169271)."
WebKit Commit Bot
Comment 7 2017-03-07 05:05:54 PST
Comment on attachment 303643 [details] Patch Clearing flags on attachment: 303643 Committed r213511: <http://trac.webkit.org/changeset/213511>
WebKit Commit Bot
Comment 8 2017-03-07 05:05:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.