Bug 169260

Summary: Well-known variations should clamp to the values listed in the @font-face block
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
Needs tests
none
CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font()
none
Needs tests
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2017-03-06 21:17:30 PST
See https://github.com/w3c/csswg-drafts/issues/782
Attachments
Needs tests (39.67 KB, patch)
2017-03-29 20:08 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font() (40.34 KB, patch)
2017-04-09 21:59 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Needs tests (46.20 KB, patch)
2017-04-11 14:55 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (49.12 KB, patch)
2017-04-11 15:19 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (49.23 KB, patch)
2017-04-11 15:21 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (49.25 KB, patch)
2017-04-11 20:50 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (49.70 KB, patch)
2017-04-11 21:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (51.81 KB, patch)
2017-04-11 21:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-03-29 20:08:47 PDT
Created attachment 305824 [details] Needs tests
Radar WebKit Bug Importer
Comment 2 2017-04-07 19:17:26 PDT
<rdar://problem/31516360>
Myles C. Maxfield
Comment 3 2017-04-09 21:59:23 PDT
Created attachment 306651 [details] CSSFontFace::m_fontSelectionCapabilities needs to be able to be optional in CSSFontFace::font()
Myles C. Maxfield
Comment 4 2017-04-11 14:55:26 PDT
Created attachment 306856 [details] Needs tests
Myles C. Maxfield
Comment 5 2017-04-11 15:19:05 PDT
Created attachment 306862 [details] Patch
Myles C. Maxfield
Comment 6 2017-04-11 15:21:38 PDT
Created attachment 306864 [details] Patch
Myles C. Maxfield
Comment 7 2017-04-11 20:50:51 PDT
Created attachment 306885 [details] Patch
Myles C. Maxfield
Comment 8 2017-04-11 21:00:56 PDT
Created attachment 306886 [details] Patch
Myles C. Maxfield
Comment 9 2017-04-11 21:51:01 PDT
Created attachment 306888 [details] Patch
Dean Jackson
Comment 10 2017-04-12 13:23:24 PDT
Comment on attachment 306888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306888&action=review > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319 > + uint32_t uniqueValue() const > + { > + return minimum.rawValue() << 16 | maximum.rawValue(); > + } > + Is that really unique?
Myles C. Maxfield
Comment 11 2017-04-12 13:24:18 PDT
(In reply to Dean Jackson from comment #10) > Comment on attachment 306888 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306888&action=review > > > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:319 > > + uint32_t uniqueValue() const > > + { > > + return minimum.rawValue() << 16 | maximum.rawValue(); > > + } > > + > > Is that really unique? This function maps two 16-bit numbers to a unique 32-bit number, so yes.
WebKit Commit Bot
Comment 12 2017-04-12 13:54:08 PDT
Comment on attachment 306888 [details] Patch Clearing flags on attachment: 306888 Committed r215287: <http://trac.webkit.org/changeset/215287>
WebKit Commit Bot
Comment 13 2017-04-12 13:54:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.