Bug 169162

Summary: Add symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit2Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ap: review+, buildbot: commit-queue-
Archive of layout-test-results from ews113 for mac-elcapitan
none
Updated patch none

Aakash Jain
Reported 2017-03-03 18:00:50 PST
Symbols from Shared/API/Cocoa/WebKit.m goes to the binary, but they are not in any header file. This causes mismatch of symbols between headers and binary, which makes TAPI unhappy. In order to ensure that symbols from headers and binary matches precisely, we should move the declaration of symbols from Shared/API/Cocoa/WebKit.m to a separate header file.
Attachments
Proposed patch (5.64 KB, patch)
2017-03-03 18:04 PST, Aakash Jain 		ap: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews113 for mac-elcapitan (1.74 MB, application/zip)
2017-03-03 20:09 PST, Build Bot 		no flags
Details
Updated patch (5.02 KB, patch)
2017-03-04 12:13 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-03-03 18:04:04 PST
Created attachment 303370 [details] Proposed patch
Build Bot
Comment 2 2017-03-03 20:09:09 PST
Comment on attachment 303370 [details] Proposed patch Attachment 303370 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3234483 New failing tests: http/tests/media/media-document.html
Build Bot
Comment 3 2017-03-03 20:09:12 PST
Created attachment 303378 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Alexey Proskuryakov
Comment 4 2017-03-03 21:36:54 PST
Comment on attachment 303370 [details] Proposed patch This looks fine to me. But there is unpleasant asymmetry with the private header, which is not compiled. Since most of the macro is duplicated anyway, I'm now thinking that this public header could also be TAPI only, and then WebKit.m won't change.
Aakash Jain
Comment 5 2017-03-04 12:13:03 PST
Created attachment 303401 [details] Updated patch > Since most of the macro is duplicated anyway, I'm now thinking that this > public header could also be TAPI only, and then WebKit.m won't change. That's a good idea. Keeps things simple and consistent. Patch updated.
WebKit Commit Bot
Comment 6 2017-03-04 13:04:00 PST
The commit-queue encountered the following flaky tests while processing attachment 303401 [details]: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html bug 169159 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-03-04 13:04:10 PST
The commit-queue encountered the following flaky tests while processing attachment 303401 [details]: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html bug 169158 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2017-03-04 13:05:34 PST
Comment on attachment 303401 [details] Updated patch Clearing flags on attachment: 303401 Committed r213428: <http://trac.webkit.org/changeset/213428>
WebKit Commit Bot
Comment 9 2017-03-04 13:05:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.