Bug 167392

Summary: REGRESSION(r210531): Relax same-volume display requirement for iOS
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, mcatanzaro, mitz
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: iOS 10   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167058
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch none

Brent Fulgham
Reported 2017-01-24 15:30:32 PST
The changes in <https://trac.webkit.org/changeset/210531> cause problems on iOS, where applications often use local HTML files for parts of their user interface, which then access other content stored in a separate volume used for downloaded media. This patch reverts this file volume check on the iOS Platform.
Attachments
Patch (1.32 KB, patch)
2017-01-24 15:40 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (825.75 KB, application/zip)
2017-01-24 16:36 PST, Build Bot 		no flags
Details
Patch (4.01 KB, patch)
2017-01-24 16:53 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-01-24 15:32:05 PST
<rdar://problem/30074665>
Brent Fulgham
Comment 2 2017-01-24 15:40:44 PST
Created attachment 299642 [details] Patch
Build Bot
Comment 3 2017-01-24 16:36:05 PST
Comment on attachment 299642 [details] Patch Attachment 299642 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2943405 New failing tests: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html storage/domstorage/sessionstorage/blocked-file-access.html
Build Bot
Comment 4 2017-01-24 16:36:08 PST
Created attachment 299652 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Brent Fulgham
Comment 5 2017-01-24 16:53:10 PST
Created attachment 299654 [details] Patch
WebKit Commit Bot
Comment 6 2017-01-24 17:44:03 PST
The commit-queue encountered the following flaky tests while processing attachment 299654 [details]: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html bug 167380 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-01-24 17:44:38 PST
Comment on attachment 299654 [details] Patch Clearing flags on attachment: 299654 Committed r211125: <http://trac.webkit.org/changeset/211125>
WebKit Commit Bot
Comment 8 2017-01-24 17:44:42 PST
All reviewed patches have been landed. Closing bug.
mitz
Comment 9 2017-01-24 19:41:33 PST
(In reply to comment #0) > The changes in <https://trac.webkit.org/changeset/210531> cause problems on > iOS, where applications often use local HTML files for parts of their user > interface, which then access other content stored in a separate volume used > for downloaded media. Can the same changes cause problems on macOS whenever the user home directory is not on the same volume as /Applications?
Brent Fulgham
Comment 10 2017-01-25 09:45:53 PST
(In reply to comment #9) > (In reply to comment #0) > > The changes in <https://trac.webkit.org/changeset/210531> cause problems on > > iOS, where applications often use local HTML files for parts of their user > > interface, which then access other content stored in a separate volume used > > for downloaded media. > > Can the same changes cause problems on macOS whenever the user home > directory is not on the same volume as /Applications? I know of no such cases, but please file a radar if you are aware of one.
Note You need to log in before you can comment on or make changes to this bug.