Bug 165339

Summary: Add Wasm floating point nearest and trunc
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165348    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-01 for mac-yosemite none

Keith Miller
Reported 2016-12-02 14:33:36 PST
Add Wasm floating point nearest and trunc
Attachments
Patch (21.52 KB, patch)
2016-12-02 14:56 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (20.21 KB, patch)
2016-12-02 19:15 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.28 KB, patch)
2016-12-02 19:57 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.21 KB, patch)
2016-12-02 19:58 PST, Keith Miller 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-01 for mac-yosemite (931.73 KB, application/zip)
2016-12-02 21:13 PST, WebKit Commit Bot 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-02 14:56:03 PST
Created attachment 296005 [details] Patch
Keith Miller
Comment 2 2016-12-02 14:59:44 PST
Committed r209275: <http://trac.webkit.org/changeset/209275>
WebKit Commit Bot
Comment 3 2016-12-02 16:34:46 PST
Re-opened since this is blocked by bug 165348
Keith Miller
Comment 4 2016-12-02 19:15:14 PST
Created attachment 296035 [details] Patch
Saam Barati
Comment 5 2016-12-02 19:28:58 PST
Comment on attachment 296035 [details] Patch r=me
WebKit Commit Bot
Comment 6 2016-12-02 19:40:36 PST
Comment on attachment 296035 [details] Patch Rejecting attachment 296035 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 296035, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/2610875
Keith Miller
Comment 7 2016-12-02 19:57:52 PST
Created attachment 296036 [details] Patch for landing
Keith Miller
Comment 8 2016-12-02 19:58:38 PST
Created attachment 296037 [details] Patch for landing
WebKit Commit Bot
Comment 9 2016-12-02 20:45:41 PST
The commit-queue encountered the following flaky tests while processing attachment 296037 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2016-12-02 20:46:16 PST
The commit-queue encountered the following flaky tests while processing attachment 296037 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2016-12-02 21:13:30 PST
Comment on attachment 296037 [details] Patch for landing Rejecting attachment 296037 [details] from commit-queue. New failing tests: media/modern-media-controls/media-controller/media-controller-resize.html Full output: http://webkit-queues.webkit.org/results/2611076
WebKit Commit Bot
Comment 12 2016-12-02 21:13:32 PST
Created attachment 296040 [details] Archive of layout-test-results from webkit-cq-01 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-yosemite Platform: Mac OS X 10.10.5
Keith Miller
Comment 13 2016-12-02 23:31:18 PST
Landed in http://trac.webkit.org/changeset/209295 and I fixed git completely failing in http://trac.webkit.org/changeset/209296.
Note You need to log in before you can comment on or make changes to this bug.