Bug 165280

Summary: Rare crash when preparing to print
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brent Fulgham
Reported 2016-12-01 14:33:46 PST
Crash trace statistics indicate a certain amount of nullptr dereferencing during some print operations. Inspecting the code revealed a number of places where the FrameView pointer was accessed without null checking, even though we null check this value everywhere else in the Frame class. This patch adds additional checks to this code to try to reduce the cases where users encounter this problem.
Attachments
Patch (2.91 KB, patch)
2016-12-01 14:38 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.94 KB, patch)
2016-12-01 14:39 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2016-12-01 16:30 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-12-01 14:38:50 PST
Created attachment 295899 [details] Patch
Brent Fulgham
Comment 2 2016-12-01 14:39:35 PST
<rdar://problem/28240254>
Brent Fulgham
Comment 3 2016-12-01 14:39:59 PST
Created attachment 295900 [details] Patch
Tim Horton
Comment 4 2016-12-01 16:22:03 PST
Comment on attachment 295900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295900&action=review > Source/WebCore/page/Frame.cpp:899 > + view->setCanHaveScrollbars(owner->scrollingMode() != ScrollbarAlwaysOff); Seems a bit odd, since we just created and set the view. And still have a reference to it.
Brent Fulgham
Comment 5 2016-12-01 16:29:24 PST
(In reply to comment #4) > Comment on attachment 295900 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295900&action=review > > > Source/WebCore/page/Frame.cpp:899 > > + view->setCanHaveScrollbars(owner->scrollingMode() != ScrollbarAlwaysOff); > > Seems a bit odd, since we just created and set the view. And still have a > reference to it. Oh! You're right. I was just blindly looking for view() calls. I'll remove that.
Brent Fulgham
Comment 6 2016-12-01 16:30:48 PST
Created attachment 295912 [details] Patch
WebKit Commit Bot
Comment 7 2016-12-01 17:31:08 PST
Comment on attachment 295912 [details] Patch Clearing flags on attachment: 295912 Committed r209226: <http://trac.webkit.org/changeset/209226>
WebKit Commit Bot
Comment 8 2016-12-01 17:31:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.