Bug 165257

Summary: Parameter to DOMStringList.contains() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, buildbot, cdumez, commit-queue, darin, dbates, esprehn+autocc, jsbell, kangil.han, kondapallykalyan, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Patch none

Chris Dumez
Reported 2016-12-01 09:34:54 PST
Parameter to DOMStringList.contains() should be mandatory. Firefox and Chrome agree with the specification. WebKit has it as optional and uses the string "undefined" as default value, which is not useful.
Attachments
Patch (4.36 KB, patch)
2016-12-01 11:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.41 MB, application/zip)
2016-12-01 11:53 PST, Build Bot 		no flags
Details
Patch (5.93 KB, patch)
2016-12-01 11:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-12-01 11:10:41 PST
Created attachment 295870 [details] Patch
Build Bot
Comment 2 2016-12-01 11:53:26 PST
Comment on attachment 295870 [details] Patch Attachment 295870 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2602448 New failing tests: storage/indexeddb/database-basics-private.html
Build Bot
Comment 3 2016-12-01 11:53:32 PST
Created attachment 295872 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Chris Dumez
Comment 4 2016-12-01 11:56:46 PST
Created attachment 295873 [details] Patch
WebKit Commit Bot
Comment 5 2016-12-01 12:33:27 PST
Comment on attachment 295873 [details] Patch Clearing flags on attachment: 295873 Committed r209193: <http://trac.webkit.org/changeset/209193>
WebKit Commit Bot
Comment 6 2016-12-01 12:33:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.