Bug 164577

Summary: Updating class name doesn't update the slotted content's style
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, jan, kangil.han, koivisto, webkit-bug-importer, webkit
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Demo
none
patch
none
patch
none
patch
rniwa: review+
patch for landing none

Ryosuke Niwa
Reported 2016-11-09 18:35:11 PST
Created attachment 294319 [details] Demo ::slotted(.selected) wouldn't apply when the class name is applied dynamically.
Attachments
Demo (586 bytes, text/html)
2016-11-09 18:35 PST, Ryosuke Niwa 		no flags
Details
patch (16.52 KB, patch)
2016-11-11 03:42 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (16.53 KB, patch)
2016-11-11 09:38 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (15.84 KB, patch)
2016-11-11 09:43 PST, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch for landing (15.93 KB, patch)
2016-11-11 14:35 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-11-10 13:27:19 PST
<rdar://problem/29205873>
Ryosuke Niwa
Comment 2 2016-11-10 15:42:40 PST
*** Bug 160865 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
Comment 3 2016-11-10 15:43:26 PST
A few more test cases listed on https://polymerlabs.github.io/wc-demos/
Antti Koivisto
Comment 4 2016-11-11 03:42:57 PST
Created attachment 294494 [details] patch
Antti Koivisto
Comment 5 2016-11-11 09:38:10 PST
Created attachment 294501 [details] patch
Antti Koivisto
Comment 6 2016-11-11 09:43:34 PST
Created attachment 294502 [details] patch
Ryosuke Niwa
Comment 7 2016-11-11 13:06:53 PST
Comment on attachment 294502 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=294502&action=review > LayoutTests/fast/shadow-dom/css-scoping-slotted-invalidation.html:86 > + Maybe we should add a test which involves multiple slots in a single shadow tree?
Antti Koivisto
Comment 8 2016-11-11 14:35:44 PST
Created attachment 294539 [details] patch for landing
WebKit Commit Bot
Comment 9 2016-11-11 15:11:40 PST
Comment on attachment 294539 [details] patch for landing Clearing flags on attachment: 294539 Committed r208616: <http://trac.webkit.org/changeset/208616>
WebKit Commit Bot
Comment 10 2016-11-11 15:11:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.