Bug 164298

Summary: LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is flaky
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164784    
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2016-11-01 15:50:06 PDT
LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html timing out https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-airplay.html
Attachments
Patch (6.12 KB, patch)
2017-01-24 13:06 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-11-01 15:50:52 PDT
Test was landed again with http://trac.webkit.org/changeset/208242, seems to be timing out on release builds.
Ryan Haddad
Comment 2 2017-01-20 13:43:52 PST
The test fails or times out on every run: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r210975%20(2974)/results.html --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-actual.txt @@ -1,13 +1,8 @@ +FAIL: Timed out waiting for notifyDone to be called Testing the PlacardSupport behavior when playing media through AirPlay. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -got event false -got event true -PASS mediaController.controls.showsPlacard is true -PASS mediaController.controls.children.includes(mediaController.controls.airplayPlacard) is true -PASS successfullyParsed is true -TEST COMPLETE - +00:0600:00
Ryan Haddad
Comment 3 2017-01-20 13:44:25 PST
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210979
Antoine Quint
Comment 4 2017-01-24 13:06:34 PST
Created attachment 299621 [details] Patch
Jon Lee
Comment 5 2017-01-24 13:15:18 PST
Comment on attachment 299621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299621&action=review > LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay.html:41 > + window.internals.setMockMediaPlaybackTargetPickerState('Sleepy TV', 'DeviceAvailable'); If there are more of these. I think we should refactor all of this setup out to a helper script.
WebKit Commit Bot
Comment 6 2017-01-24 19:01:16 PST
Comment on attachment 299621 [details] Patch Clearing flags on attachment: 299621 Committed r211132: <http://trac.webkit.org/changeset/211132>
WebKit Commit Bot
Comment 7 2017-01-24 19:01:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.