Bug 163738

Summary: The tracking of the coarse-grain Heap state (allocating or not, collector or not, eden vs full) should respect the orthogonality between allocating and collecting
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 163562    
Attachments:
Description Flags
it begins
none
more
none
maybe it's done
none
more
none
getting closer
none
the patch
none
the patch
ggaren: review+
possible patch for landing
none
possible patch for landing
none
possible patch for landing none

Filip Pizlo
Reported 2016-10-20 09:56:38 PDT
Patch forthcoming.
Attachments
it begins (52.92 KB, patch)
2016-10-20 09:57 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (63.64 KB, patch)
2016-10-20 10:07 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
maybe it's done (73.49 KB, patch)
2016-10-20 11:25 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (81.26 KB, patch)
2016-10-20 11:44 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
getting closer (93.29 KB, patch)
2016-10-20 13:17 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (103.76 KB, patch)
2016-10-20 15:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (104.28 KB, patch)
2016-10-20 15:08 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
possible patch for landing (105.71 KB, patch)
2016-10-20 15:42 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
possible patch for landing (106.06 KB, patch)
2016-10-20 15:49 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
possible patch for landing (106.16 KB, patch)
2016-10-20 16:20 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-10-20 09:57:22 PDT
Created attachment 292213 [details] it begins
Filip Pizlo
Comment 2 2016-10-20 10:07:33 PDT
Created attachment 292215 [details] more
Filip Pizlo
Comment 3 2016-10-20 11:25:36 PDT
Created attachment 292227 [details] maybe it's done
Filip Pizlo
Comment 4 2016-10-20 11:44:03 PDT
Created attachment 292232 [details] more More things are happy.
Filip Pizlo
Comment 5 2016-10-20 13:17:22 PDT
Created attachment 292242 [details] getting closer
Filip Pizlo
Comment 6 2016-10-20 15:00:18 PDT
Created attachment 292265 [details] the patch
Filip Pizlo
Comment 7 2016-10-20 15:08:41 PDT
Created attachment 292266 [details] the patch
Filip Pizlo
Comment 8 2016-10-20 15:34:16 PDT
I'm fixing the WebCore build errors.
Geoffrey Garen
Comment 9 2016-10-20 15:39:05 PDT
Comment on attachment 292266 [details] the patch r=me when it builds
Filip Pizlo
Comment 10 2016-10-20 15:42:43 PDT
Created attachment 292272 [details] possible patch for landing Fixing WebCore things.
Filip Pizlo
Comment 11 2016-10-20 15:49:37 PDT
Created attachment 292275 [details] possible patch for landing
Filip Pizlo
Comment 12 2016-10-20 16:20:01 PDT
Created attachment 292277 [details] possible patch for landing I think it might build now.
Filip Pizlo
Comment 13 2016-10-20 17:01:33 PDT
I'll run JetStream and then land.
Filip Pizlo
Comment 14 2016-10-20 19:18:05 PDT
(In reply to comment #13) > I'll run JetStream and then land. It's neutral (0.3% slower with 54% confidence).
Filip Pizlo
Comment 15 2016-10-20 19:23:43 PDT
Landed in https://trac.webkit.org/changeset/207653
Note You need to log in before you can comment on or make changes to this bug.