Bug 162078

Summary: [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 46591    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch dino: review+

Dave Hyatt
Reported 2016-09-16 11:40:43 PDT
[CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
Attachments
Patch (85.26 KB, patch)
2016-09-16 12:03 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (85.19 KB, patch)
2016-09-16 12:08 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (85.21 KB, patch)
2016-09-16 12:11 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (86.50 KB, patch)
2016-09-16 12:39 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-09-16 12:03:04 PDT
Created attachment 289087 [details] Patch
WebKit Commit Bot
Comment 2 2016-09-16 12:05:09 PDT
Attachment 289087 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSCalculationValue.cpp:609: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/parser/CSSParserIdioms.h:69: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:579: 'result' is incorrectly named. It should be named 'protector' or 'protectedNullptr'. [readability/naming/protected] [4] ERROR: Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:998: 'result' is incorrectly named. It should be named 'protector' or 'protectedNullptr'. [readability/naming/protected] [4] Total errors found: 6 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2016-09-16 12:08:15 PDT
Created attachment 289090 [details] Patch
WebKit Commit Bot
Comment 4 2016-09-16 12:10:41 PDT
Attachment 289090 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 5 2016-09-16 12:11:57 PDT
Created attachment 289092 [details] Patch
WebKit Commit Bot
Comment 6 2016-09-16 12:13:33 PDT
Attachment 289092 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 7 2016-09-16 12:39:01 PDT
Created attachment 289094 [details] Patch
WebKit Commit Bot
Comment 8 2016-09-16 12:41:12 PDT
Attachment 289094 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSPrimitiveValue.h:159: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/css/CSSPrimitiveValue.h:165: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 9 2016-09-16 12:55:42 PDT
Comment on attachment 289094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289094&action=review > Source/WebCore/css/CSSCalculationValue.cpp:900 > + return expression ? adoptRef(new CSSCalcValue(expression.releaseNonNull(), range != ValueRangeAll)) : nullptr; > + > +} Nit: extra blank line
Dave Hyatt
Comment 10 2016-09-16 13:26:43 PDT
Landed in r206043.
Note You need to log in before you can comment on or make changes to this bug.