Bug 161425

Summary: Add "whenDefined" to CustomElementRegistry
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, kling, koivisto, kondapallykalyan, webkit-bug-importer, ysuzuki
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 161426    
Bug Blocks: 154907    
Attachments:
Description Flags
Added the support
none
Fixed change logs
ysuzuki: review+, buildbot: commit-queue-
Archive of layout-test-results from ews115 for mac-yosemite none

Ryosuke Niwa
Reported 2016-08-30 22:30:35 PDT
Add the support for “whenDefined” method on CustomElementRegistry: https://html.spec.whatwg.org/#dom-customelementregistry-whendefined
Attachments
Added the support (19.38 KB, patch)
2016-08-31 20:07 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed change logs (19.34 KB, patch)
2016-08-31 20:09 PDT, Ryosuke Niwa 		ysuzuki: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-yosemite (1.50 MB, application/zip)
2016-08-31 21:50 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-08-31 20:07:10 PDT
Created attachment 287587 [details] Added the support
Ryosuke Niwa
Comment 2 2016-08-31 20:09:51 PDT
Created attachment 287588 [details] Fixed change logs
Build Bot
Comment 3 2016-08-31 21:50:50 PDT
Comment on attachment 287588 [details] Fixed change logs Attachment 287588 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1984634 New failing tests: fast/dom/HTMLElement/class-list-gc.html
Build Bot
Comment 4 2016-08-31 21:50:55 PDT
Created attachment 287598 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Yusuke Suzuki
Comment 5 2016-09-01 14:01:23 PDT
Comment on attachment 287588 [details] Fixed change logs View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review r=me > Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188 > + return jsUndefined(); Adding a test for this case would be nice.
Ryosuke Niwa
Comment 6 2016-09-01 14:02:58 PDT
Comment on attachment 287588 [details] Fixed change logs View in context: https://bugs.webkit.org/attachment.cgi?id=287588&action=review Thanks for the review! >> Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:188 >> + return jsUndefined(); > > Adding a test for this case would be nice. Oh oops, I did have some test cases but somehow got lost during merge. Will add them back.
Ryosuke Niwa
Comment 7 2016-09-01 14:48:29 PDT
Landed in https://trac.webkit.org/changeset/205315.
Ryosuke Niwa
Comment 8 2016-09-01 16:17:58 PDT
<rdar://problem/28091073>
Note You need to log in before you can comment on or make changes to this bug.