Bug 159200

Summary: [css-grid] Disallow repeat() in grid-template shorthand
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=614314
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2016-06-28 01:24:14 PDT
As discussed on www-style, "repeat()" notation shouldn't be allowed in the ASCII branch of the grid-template shorthand. See: https://lists.w3.org/Archives/Public/www-style/2016May/0193.html The syntax on the spec has been updated and avoid the use of <track-list>: https://drafts.csswg.org/css-grid/#grid-template-ascii For example the following declaration should be invalid: grid-template: "a b" / repeat(2, 100px);
Attachments
Patch (16.59 KB, patch)
2016-06-28 02:14 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (16.74 KB, patch)
2016-07-06 06:01 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-06-28 02:14:13 PDT
Created attachment 282227 [details] Patch
Sergio Villar Senin
Comment 2 2016-07-06 02:50:06 PDT
Comment on attachment 282227 [details] Patch Nice patch but better use an enumerated type instead of a boolean.
Manuel Rego Casasnovas
Comment 3 2016-07-06 06:01:30 PDT
Created attachment 282883 [details] Patch Thanks for the review, new patch using an enum uploaded. PTAL.
WebKit Commit Bot
Comment 4 2016-07-08 01:58:29 PDT
Comment on attachment 282883 [details] Patch Clearing flags on attachment: 282883 Committed r202972: <http://trac.webkit.org/changeset/202972>
WebKit Commit Bot
Comment 5 2016-07-08 01:58:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.