Bug 157289

Summary: Add/refactor isolatedCopy methods for 3 IDB classes
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 149953    
Attachments:
Description Flags
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Patch for landing none

Brady Eidson
Reported 2016-05-02 17:13:27 PDT
Add/refactor isolatedCopy methods for 3 IDB classes Needed for upcoming, larger patches.
Attachments
Patch v1 (8.65 KB, patch)
2016-05-02 17:20 PDT, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.26 MB, application/zip)
2016-05-02 17:43 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews102 for mac-yosemite (1.37 MB, application/zip)
2016-05-02 17:45 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (763.06 KB, application/zip)
2016-05-02 18:10 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-yosemite (1.05 MB, application/zip)
2016-05-02 18:19 PDT, Build Bot 		no flags
Details
Patch for landing (8.65 KB, patch)
2016-05-02 21:43 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-05-02 17:20:25 PDT
Created attachment 277950 [details] Patch v1
Build Bot
Comment 2 2016-05-02 17:43:56 PDT
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1258240 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2016-05-02 17:43:58 PDT
Created attachment 277951 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-05-02 17:45:53 PDT
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1258254 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-05-02 17:45:56 PDT
Created attachment 277952 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-05-02 18:10:06 PDT
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1258307 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2016-05-02 18:10:08 PDT
Created attachment 277954 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Build Bot
Comment 8 2016-05-02 18:19:01 PDT
Comment on attachment 277950 [details] Patch v1 Attachment 277950 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1258313 Number of test failures exceeded the failure limit.
Build Bot
Comment 9 2016-05-02 18:19:04 PDT
Created attachment 277956 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 10 2016-05-02 18:32:12 PDT
Well those failures are obviously tragic. Building locally.
Brady Eidson
Comment 11 2016-05-02 21:43:13 PDT
Created attachment 277977 [details] Patch for landing
WebKit Commit Bot
Comment 12 2016-05-03 08:30:16 PDT
Comment on attachment 277977 [details] Patch for landing Clearing flags on attachment: 277977 Committed r200372: <http://trac.webkit.org/changeset/200372>
WebKit Commit Bot
Comment 13 2016-05-03 08:30:22 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 14 2016-05-03 11:12:38 PDT
Comment on attachment 277977 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=277977&action=review > Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:85 > + destination.m_identifier = source.m_identifier.isolatedCopy(); aha!
Note You need to log in before you can comment on or make changes to this bug.