Bug 156264

Summary: Modern IDB: Make sure SQLite backing store records have a INTEGER PRIMARY KEY column
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 143193    
Attachments:
Description Flags
WIP
none
Patch v1
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Archive of layout-test-results from ews112 for mac-yosemite
none
Patch v2 - Whoops none

Brady Eidson
Reported 2016-04-05 16:59:16 PDT
Modern IDB: Make sure SQLite backing store records have a PRIMARY KEY AUTOINCREMENT column This is because the rowID will be needed to support Blobs in the database... but unless there's a PRIMARY KEY column the rowIDs might change (e.g. when vacuuming)
Attachments
WIP (2.87 KB, application/octet-stream)
2016-04-05 17:21 PDT, Brady Eidson 		no flags
Details
Patch v1 (4.69 KB, patch)
2016-04-05 21:23 PDT, Brady Eidson 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (928.51 KB, application/zip)
2016-04-05 21:42 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.04 MB, application/zip)
2016-04-05 22:09 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (726.96 KB, application/zip)
2016-04-05 22:11 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews112 for mac-yosemite (804.27 KB, application/zip)
2016-04-05 22:15 PDT, Build Bot 		no flags
Details
Patch v2 - Whoops (6.51 KB, patch)
2016-04-06 11:22 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-04-05 17:05:56 PDT
INTEGER PRIMARY KEY, not AUTOINCREMENT.
Brady Eidson
Comment 2 2016-04-05 17:21:06 PDT
Created attachment 275725 [details] WIP WIP patch, untested (still building...) But it should really be this easy.
Brady Eidson
Comment 3 2016-04-05 21:23:44 PDT
Created attachment 275745 [details] Patch v1
Build Bot
Comment 4 2016-04-05 21:42:34 PDT
Comment on attachment 275745 [details] Patch v1 Attachment 275745 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1107195 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-04-05 21:42:37 PDT
Created attachment 275750 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-04-05 22:09:45 PDT
Comment on attachment 275745 [details] Patch v1 Attachment 275745 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1107304 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2016-04-05 22:09:47 PDT
Created attachment 275753 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-04-05 22:11:48 PDT
Comment on attachment 275745 [details] Patch v1 Attachment 275745 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1107286 Number of test failures exceeded the failure limit.
Build Bot
Comment 9 2016-04-05 22:11:50 PDT
Created attachment 275754 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 10 2016-04-05 22:15:05 PDT
Comment on attachment 275745 [details] Patch v1 Attachment 275745 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1107283 Number of test failures exceeded the failure limit.
Build Bot
Comment 11 2016-04-05 22:15:08 PDT
Created attachment 275756 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 12 2016-04-06 11:22:43 PDT
Created attachment 275786 [details] Patch v2 - Whoops
WebKit Commit Bot
Comment 13 2016-04-06 15:25:39 PDT
Comment on attachment 275786 [details] Patch v2 - Whoops Clearing flags on attachment: 275786 Committed r199120: <http://trac.webkit.org/changeset/199120>
WebKit Commit Bot
Comment 14 2016-04-06 15:25:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.