Bug 155062

Summary: Add the support for upgrading custom elements in cloneNode
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Adds the support
none
Minor fix in change log
none
Fix GTK/EFL builds
none
Patch for landing none

Ryosuke Niwa
Reported 2016-03-05 00:36:44 PST
Node.prototype.cloneNode should support upgrading custom elements.
Attachments
Adds the support (33.37 KB, patch)
2016-03-05 01:08 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Minor fix in change log (33.37 KB, patch)
2016-03-05 01:08 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fix GTK/EFL builds (33.41 KB, patch)
2016-03-05 01:12 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.83 KB, patch)
2016-03-05 01:27 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-03-05 00:37:12 PST
<rdar://problem/24949463>
Ryosuke Niwa
Comment 2 2016-03-05 01:08:08 PST
Created attachment 273072 [details] Adds the support
Ryosuke Niwa
Comment 3 2016-03-05 01:08:59 PST
Created attachment 273073 [details] Minor fix in change log
Ryosuke Niwa
Comment 4 2016-03-05 01:12:07 PST
Created attachment 273075 [details] Fix GTK/EFL builds
Antti Koivisto
Comment 5 2016-03-05 01:15:08 PST
Comment on attachment 273075 [details] Fix GTK/EFL builds View in context: https://bugs.webkit.org/attachment.cgi?id=273075&action=review > Source/WebCore/dom/LifecycleCallbackQueue.cpp:51 > + , m_attributeName(nullQName()) This isn't needed.
Ryosuke Niwa
Comment 6 2016-03-05 01:18:06 PST
(In reply to comment #5) > Comment on attachment 273075 [details] > Fix GTK/EFL builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273075&action=review > > > Source/WebCore/dom/LifecycleCallbackQueue.cpp:51 > > + , m_attributeName(nullQName()) > > This isn't needed. Actually, it's needed on Mac port :( Compiler will complain otherwise. I guess QNAME_DEFAULT_CONSTRUCTOR is false at http://trac.webkit.org/browser/trunk/Source/WebCore/dom/QualifiedName.h#L76 #ifdef QNAME_DEFAULT_CONSTRUCTOR QualifiedName() { } #endif
Ryosuke Niwa
Comment 7 2016-03-05 01:27:00 PST
I'm going to use Optional<QualifiedName> instead as discussed on IRC.
Ryosuke Niwa
Comment 8 2016-03-05 01:27:32 PST
Created attachment 273078 [details] Patch for landing
Ryosuke Niwa
Comment 9 2016-03-05 01:27:47 PST
Comment on attachment 273078 [details] Patch for landing Wait for EWS first.
Ryosuke Niwa
Comment 10 2016-03-05 21:07:35 PST
Committed r197634: <http://trac.webkit.org/changeset/197634>
Note You need to log in before you can comment on or make changes to this bug.