Bug 154121

Summary:

[Web IDL] interfaces should inherit EventTarget instead of duplicating the EventTarget API

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, cgarcia, commit-queue, darin, dominicc, ggaren, jiewen_tan, joepeck, mcatanzaro, oliver, sam, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

154170

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2016-02-11 12:08:25 PST

interfaces should inherit EventTarget instead of duplicating the EventTarget API in their IDL. We should also be able to get rid of the [EventTarget] WebKit IDL attribute in a follow-up.

Attachments
WIP Patch (65.71 KB, patch) 2016-02-11 13:57 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (99.78 KB, patch) 2016-02-11 14:52 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (99.90 KB, patch) 2016-02-11 15:37 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (101.25 KB, patch) 2016-02-11 16:05 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (100.04 KB, patch) 2016-02-11 16:15 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (100.32 KB, patch) 2016-02-11 16:23 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (100.39 KB, patch) 2016-02-11 16:31 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (100.61 KB, patch) 2016-02-11 18:43 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (108.92 KB, patch) 2016-02-11 20:23 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (108.89 KB, patch) 2016-02-11 20:30 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-02-11 12:14:31 PST

<rdar://problem/24613234>

Chris Dumez

Comment 2 2016-02-11 13:57:28 PST

Created attachment 271083 [details] WIP Patch

Chris Dumez

Comment 3 2016-02-11 14:52:00 PST

Created attachment 271094 [details] WIP Patch

Chris Dumez

Comment 4 2016-02-11 15:37:29 PST

Created attachment 271098 [details] WIP Patch

Chris Dumez

Comment 5 2016-02-11 16:05:35 PST

Created attachment 271099 [details] WIP Patch

Chris Dumez

Comment 6 2016-02-11 16:14:40 PST

Struggling a bit to get the GObject bindings right.

Chris Dumez

Comment 7 2016-02-11 16:15:05 PST

Created attachment 271100 [details] WIP Patch

Chris Dumez

Comment 8 2016-02-11 16:23:29 PST

Created attachment 271101 [details] WIP Patch

Chris Dumez

Comment 9 2016-02-11 16:31:52 PST

Created attachment 271105 [details] WIP Patch

Chris Dumez

Comment 10 2016-02-11 18:43:37 PST

Created attachment 271116 [details] WIP Patch

Chris Dumez

Comment 11 2016-02-11 20:23:34 PST

Created attachment 271126 [details] Patch

Chris Dumez

Comment 12 2016-02-11 20:30:34 PST

Created attachment 271127 [details] Patch

WebKit Commit Bot

Comment 13 2016-02-11 23:28:35 PST

Comment on attachment 271127 [details] Patch Clearing flags on attachment: 271127 Committed r196466: <http://trac.webkit.org/changeset/196466>

WebKit Commit Bot

Comment 14 2016-02-11 23:28:41 PST

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 15 2016-02-12 08:41:47 PST

Comment on attachment 271127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review I love this patch. One tiny thing in it that I find irritating is the argument name "domObject"; I probably would have suggested "wrappableObject" instead, since I like words much better than acronyms and jargon. > Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32 > +] interface SpeechSynthesisUtterance : EventTarget > +{ Small editing mistake: Why add this new line break in just this one file?

Darin Adler

Comment 16 2016-02-12 08:42:38 PST

Comment on attachment 271127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review > Source/WebCore/dom/WebKitNamedFlow.idl:37 > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > +: EventTarget > +#endif Elsewhere we indented lines like the EventTarget one here.

Chris Dumez

Comment 17 2016-02-12 08:44:57 PST

Comment on attachment 271127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review >> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32 >> +{ > > Small editing mistake: Why add this new line break in just this one file? Yes indeed, I'll fix it now. Thanks. >> Source/WebCore/dom/WebKitNamedFlow.idl:37 >> +#endif > > Elsewhere we indented lines like the EventTarget one here. Actually, I was supposed to drop the #ifdefing. I'll do that.

Chris Dumez

Comment 18 2016-02-12 08:49:19 PST

Updated as per Darin's feedback in <http://trac.webkit.org/changeset/196476>.

Alexey Shvayka

Comment 19 2021-03-17 04:46:18 PDT

*** Bug 67329 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.