Bug 152896

Summary: Modern IDB: Blocked event can fire on a delete request even after the last open connection has closed
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882, 152554    
Attachments:
Description Flags
Patch v1
none
Patch v1 achristensen: review+, achristensen: commit-queue-

Brady Eidson
Reported 2016-01-08 09:44:39 PST
Modern IDB: Blocked event can fire on a delete request even after the last open connection has closed Fixing this fixes lots of tests.
Attachments
Patch v1 (17.74 KB, patch)
2016-01-08 10:42 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 (17.72 KB, patch)
2016-01-08 10:44 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-08 10:42:34 PST
Created attachment 268549 [details] Patch v1
WebKit Commit Bot
Comment 2 2016-01-08 10:43:35 PST
Attachment 268549 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:195: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2016-01-08 10:44:32 PST
Created attachment 268550 [details] Patch v1
Alex Christensen
Comment 4 2016-01-08 12:26:25 PST
Comment on attachment 268550 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=268550&action=review > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:232 > + else > + m_databaseInfo = nullptr; This is already null. Not necessary.
Brady Eidson
Comment 5 2016-01-08 13:12:55 PST
https://trac.webkit.org/changeset/194781
Note You need to log in before you can comment on or make changes to this bug.