Bug 150713

Summary: REGRESSION(r191776): EFL build broken.
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, gyuyoung.kim, jsbell, lucas.de.marchi, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150695    
Attachments:
Description Flags
Patch
none
Patch none

Hunseop Jeong
Reported 2015-10-29 23:03:52 PDT
../../Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp: In member function ‘void WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd(uint64_t, const WebCore::IDBResourceIdentifier&, uint64_t, const WebCore::IDBKeyData&, const WebCore::ThreadSafeDataBuffer&, WebCore::IndexedDB::ObjectStoreOverwriteMode)’: ../../Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:316:10: error: variable ‘keyWasGenerated’ set but not used [-Werror=unused-but-set-variable] bool keyWasGenerated = false; ^
Attachments
Patch (1.26 KB, patch)
2015-10-29 23:09 PDT, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.31 KB, patch)
2015-10-30 00:12 PDT, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hunseop Jeong
Comment 1 2015-10-29 23:09:43 PDT
Created attachment 264382 [details] Patch
Hunseop Jeong
Comment 2 2015-10-29 23:10:10 PDT
EFL build failed because 'keyWasGenerated' was unused. Do you have additional patch to use the 'keyWasGenerated'?
Alex Christensen
Comment 3 2015-10-30 00:09:12 PDT
Comment on attachment 264382 [details] Patch Just remove keyWasGenerated completely. It is indeed not used, and if we need to use it, we will add it. rs=me for doing that.
Hunseop Jeong
Comment 4 2015-10-30 00:12:23 PDT
Created attachment 264384 [details] Patch
Hunseop Jeong
Comment 5 2015-10-30 00:13:03 PDT
(In reply to comment #3) > Comment on attachment 264382 [details] > Patch > > Just remove keyWasGenerated completely. It is indeed not used, and if we > need to use it, we will add it. rs=me for doing that. Okay, I removed it.
WebKit Commit Bot
Comment 6 2015-10-30 01:02:06 PDT
Comment on attachment 264384 [details] Patch Clearing flags on attachment: 264384 Committed r191781: <http://trac.webkit.org/changeset/191781>
WebKit Commit Bot
Comment 7 2015-10-30 01:02:10 PDT
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 8 2015-10-30 06:17:31 PDT
Sorry, didn't see this because the EFL bot was in the "build broken even without this patch" state
Note You need to log in before you can comment on or make changes to this bug.