Bug 150543

Summary: Modern IDB: Backing store objectStores (plumbing for b/150468)
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150468    
Attachments:
Description Flags
Patch v1
beidson: review-
Patch v2
none
Patch v3
none
Patch v4 - Attempt to placate busted gcc achristensen: review+

Brady Eidson
Reported 2015-10-24 21:50:07 PDT
Modern IDB: Backing store objectStores (plumbing for b/150468) This is followup to https://bugs.webkit.org/show_bug.cgi?id=150455, but untestable until https://bugs.webkit.org/show_bug.cgi?id=150468 Why separate from 150468? Makes both this and 150468 smaller patches to review.
Attachments
Patch v1 (22.85 KB, patch)
2015-10-24 21:55 PDT, Brady Eidson 		beidson: review-
DetailsFormatted DiffDiff
Patch v2 (22.85 KB, patch)
2015-10-25 10:24 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v3 (22.87 KB, patch)
2015-10-25 11:10 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v4 - Attempt to placate busted gcc (22.88 KB, patch)
2015-10-25 11:27 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-10-24 21:55:53 PDT
Created attachment 264002 [details] Patch v1
Brady Eidson
Comment 2 2015-10-24 22:05:38 PDT
My tree is two days out of date. I was hoping this patch would build without having to update... oh well! r- for now until I can rebase and rebuild.
Brady Eidson
Comment 3 2015-10-25 10:24:14 PDT
Created attachment 264011 [details] Patch v2
Brady Eidson
Comment 4 2015-10-25 11:08:18 PDT
Guh. Okay...
Brady Eidson
Comment 5 2015-10-25 11:10:37 PDT
Created attachment 264015 [details] Patch v3
Brady Eidson
Comment 6 2015-10-25 11:27:00 PDT
Created attachment 264016 [details] Patch v4 - Attempt to placate busted gcc
Alex Christensen
Comment 7 2015-10-26 10:18:11 PDT
Comment on attachment 264016 [details] Patch v4 - Attempt to placate busted gcc View in context: https://bugs.webkit.org/attachment.cgi?id=264016&action=review > Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:110 > + if (m_databaseInfo->hasObjectStore(info.name())) ASSERT(m_databaseInfo);
Alex Christensen
Comment 8 2015-10-26 10:20:44 PDT
Comment on attachment 264016 [details] Patch v4 - Attempt to placate busted gcc View in context: https://bugs.webkit.org/attachment.cgi?id=264016&action=review > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:225 > + m_backingStore->createObjectStore(transaction.info().identifier(), info); ASSERT(m_backingStore)
Brady Eidson
Comment 9 2015-10-26 14:08:23 PDT
https://trac.webkit.org/changeset/191598
Note You need to log in before you can comment on or make changes to this bug.