Bug 149725

Summary: Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Collapsed toolbar
none
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Matt Baker
Reported 2015-10-01 14:59:07 PDT
Created attachment 262286 [details] [Image] Collapsed toolbar * SUMMARY Toolbar collapses when inspector at minimum height with console open. It's easier to reproduce with the inspector docked at the bottom. * STEPS TO REPRODUCE 1. Open Inspector > any tab except Console 2. Expand the console, drag to maximum height 3. Decrease inspector window height to the minimum height => Toolbar and tab bar collapse rather than stopping once the top of the console is hit *NOTES Regressed in http://trac.webkit.org/changeset/189567. The patch changed the min-width/height defaults to auto for flex box items. Per the patch notes, we should be setting: min-width: 0; min-height: 0; for any flex items.
Attachments
[Image] Collapsed toolbar (252.37 KB, image/png)
2015-10-01 14:59 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (1.44 KB, patch)
2015-10-01 15:22 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (1.45 KB, patch)
2015-10-01 15:43 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-01 14:59:56 PDT
<rdar://problem/22941366>
Matt Baker
Comment 2 2015-10-01 15:22:50 PDT
Created attachment 262287 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 3 2015-10-01 15:24:42 PDT
Comment on attachment 262287 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=262287&action=review > Source/WebInspectorUI/ChangeLog:13 > + (*): min-width: 0; min-height: 0; for all elements. Putting this on "*" is a pretty heavy handed. We should make a targeted fix for the toolbar and start relying on the new default behavior instead of the old default behavior.
Matt Baker
Comment 4 2015-10-01 15:43:53 PDT
Created attachment 262291 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2015-10-01 16:33:33 PDT
Comment on attachment 262291 [details] [Patch] Proposed Fix Clearing flags on attachment: 262291 Committed r190436: <http://trac.webkit.org/changeset/190436>
WebKit Commit Bot
Comment 6 2015-10-01 16:33:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.