Bug 149558

Summary: PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, bdakin, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1 bdakin: review+

Brady Eidson
Reported 2015-09-25 12:20:59 PDT
PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code As I fill in IDB interfaces in the modern IDB implementation, I'd rather not be dealing with PassRefPtr at all.
Attachments
Patch v1 (85.28 KB, patch)
2015-09-25 12:24 PDT, Brady Eidson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-09-25 12:24:08 PDT
Created attachment 261932 [details] Patch v1
WebKit Commit Bot
Comment 2 2015-09-25 12:25:51 PDT
Attachment 261932 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBDatabaseError.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyObjectStore.h:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyCursor.h:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBAny.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBDatabase.h:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 8 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2015-09-25 12:47:30 PDT
https://trac.webkit.org/changeset/190250
Note You need to log in before you can comment on or make changes to this bug.