Bug 143170

Summary: parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, joepeck, rniwa, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Cleanup benjamin: review+

Ryosuke Niwa
Reported 2015-03-27 18:39:08 PDT
parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
Attachments
Cleanup (1.41 KB, patch)
2015-03-27 18:42 PDT, Ryosuke Niwa 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-03-27 18:42:48 PDT
Created attachment 249632 [details] Cleanup
Ryosuke Niwa
Comment 2 2015-03-27 18:43:47 PDT
Comment on attachment 249632 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review > Source/JavaScriptCore/ChangeLog:9 > + since both base and derived default constructors should be using a 8-bit string. That is, two string literals we have in BuiltinExecutables::createDefaultConstructor.
Benjamin Poulain
Comment 3 2015-03-27 20:05:32 PDT
Comment on attachment 249632 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review > Source/JavaScriptCore/parser/Parser.h:1009 > + ASSERT(defaultConstructorKind == ConstructorKind::None); ASSERT -> ASSERT_WITH_MESSAGE.
Ryosuke Niwa
Comment 4 2015-03-27 21:03:31 PDT
Committed r182102: <http://trac.webkit.org/changeset/182102>
Note You need to log in before you can comment on or make changes to this bug.