Bug 142690

Summary: ES6 class syntax should allow computed name method
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, joepeck, mmirman, msaboff, saam, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Fixes the bug
none
Updated for ToT
none
Updated for ToT again
none
Fixes the bug
none
Adds the support
none
Updated for ToT
none
Fixed 32-bit build none

Ryosuke Niwa
Reported 2015-03-13 23:59:34 PDT
Adopt Joe's computed property goodness in ES6 class syntax.
Attachments
Fixes the bug (21.37 KB, patch)
2015-03-14 00:06 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT (21.34 KB, patch)
2015-03-16 22:16 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT again (21.23 KB, patch)
2015-03-16 23:06 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (7.46 KB, patch)
2015-03-31 13:55 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds the support (59.30 KB, patch)
2015-08-13 22:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT (59.28 KB, patch)
2015-08-14 12:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed 32-bit build (61.65 KB, patch)
2015-08-14 13:39 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-03-14 00:06:38 PDT
Created attachment 248641 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2015-03-16 22:16:51 PDT
Created attachment 248819 [details] Updated for ToT
Ryosuke Niwa
Comment 3 2015-03-16 23:06:36 PDT
Created attachment 248828 [details] Updated for ToT again
Ryosuke Niwa
Comment 4 2015-03-27 23:03:05 PDT
Comment on attachment 248828 [details] Updated for ToT again This no longer applies on ToT.
Ryosuke Niwa
Comment 5 2015-03-31 13:55:17 PDT
Created attachment 249848 [details] Fixes the bug
Ryosuke Niwa
Comment 6 2015-03-31 13:55:53 PDT
Comment on attachment 249848 [details] Fixes the bug Wrong bug.
Ryosuke Niwa
Comment 7 2015-08-13 22:54:12 PDT
Created attachment 258984 [details] Adds the support
Ryosuke Niwa
Comment 8 2015-08-14 12:40:34 PDT
Created attachment 259027 [details] Updated for ToT
Ryosuke Niwa
Comment 9 2015-08-14 13:39:28 PDT
Created attachment 259032 [details] Fixed 32-bit build
Saam Barati
Comment 10 2015-08-14 16:48:50 PDT
Comment on attachment 259032 [details] Fixed 32-bit build r=me I think it'd be good to have tests for computed method names that have side effects and we should assert that we do things in the correct order: "[(x = 20, "foo")] {..}, [assert(x === 20), "bar"] {...}". Ryosuke says he will open up another bug for this.
Ryosuke Niwa
Comment 11 2015-08-14 16:50:46 PDT
Comment on attachment 259032 [details] Fixed 32-bit build Clearing flags on attachment: 259032 Committed r188498: <http://trac.webkit.org/changeset/188498>
Ryosuke Niwa
Comment 12 2015-08-14 16:50:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.