Bug 135473

Created attachment 235853 [details] Patch

Comment on attachment 235853 [details] Patch Attachment 235853 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4503659933073408 New failing tests: http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html fast/history/timed-refresh-in-cached-frame.html platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html media/restore-from-page-cache.html http/tests/navigation/https-in-page-cache.html animations/resume-after-page-cache.html fast/forms/autocomplete-off-with-default-value-does-not-clear.html compositing/iframes/page-cache-layer-tree.html fast/overflow/horizontal-scroll-after-back.html fast/events/pagehide-xhr-open.html fast/dom/Window/timer-resume-on-navigation-back.html loader/go-back-cached-main-resource.html fast/events/suspend-timers.html fast/images/animated-gif-restored-from-bfcache.html http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html

Created attachment 235862 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 235853 [details] Patch Attachment 235853 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4657150253072384 New failing tests: http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html fast/history/timed-refresh-in-cached-frame.html platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html media/restore-from-page-cache.html http/tests/navigation/https-in-page-cache.html animations/resume-after-page-cache.html fast/forms/autocomplete-off-with-default-value-does-not-clear.html compositing/iframes/page-cache-layer-tree.html fast/overflow/horizontal-scroll-after-back.html fast/events/pagehide-xhr-open.html fast/dom/Window/timer-resume-on-navigation-back.html loader/go-back-cached-main-resource.html fast/events/suspend-timers.html fast/images/animated-gif-restored-from-bfcache.html http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html

Created attachment 235866 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 235853 [details] Patch Attachment 235853 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6473003370020864 New failing tests: fast/harness/use-page-cache.html media/restore-from-page-cache.html http/tests/navigation/https-in-page-cache.html fast/images/animated-gif-restored-from-bfcache.html http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html fast/history/timed-refresh-in-cached-frame.html plugins/crash-restoring-plugin-page-from-page-cache.html platform/mac/editing/input/unconfirmed-text-navigation-with-page-cache.html fast/forms/autocomplete-off-with-default-value-does-not-clear.html compositing/iframes/page-cache-layer-tree.html fast/events/pageshow-pagehide-on-back-cached.html fast/harness/page-cache-crash-on-data-urls.html fast/loader/window-properties-restored-from-page-cache.html fast/events/pageshow-pagehide-on-back-cached-with-frames.html animations/resume-after-page-cache.html fast/overflow/horizontal-scroll-after-back.html fast/events/pagehide-xhr-open.html fast/dom/Window/timer-resume-on-navigation-back.html loader/go-back-cached-main-resource.html http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html plugins/netscape-plugin-page-cache-works.html platform/mac/fast/scrolling/scroll-select-bottom-test.html fast/events/pagehide-timeout.html fast/events/suspend-timers.html

Created attachment 235867 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 237583 [details] Updated Patch Fixed bug 136044, which originally caused the test failures. Re-uploading to see what happens.

Comment on attachment 237583 [details] Updated Patch Rejecting attachment 237583 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 237583, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: unk FAILED -- saving rejects to file Source/WebKit2/Configurations/FeatureDefines.xcconfig.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1401. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6002615666081792

Created attachment 237968 [details] Updated patch Merging with trunk to fix up conflicts.

Comment on attachment 237968 [details] Updated patch Clearing flags on attachment: 237968 Committed r173531: <http://trac.webkit.org/changeset/173531>

All reviewed patches have been landed. Closing bug.

It looks like this API has been changed in the latest spec. See bugs 141937 and 141938.