Bug 135393

Summary: [CSS Font Loading] Rename document.fontloader to document.fonts
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-font-loading/#font-face-source
Bug Depends on:    
Bug Blocks: 135390    
Attachments:
Description Flags
Initial Patch
bjonesbe: review+, bjonesbe: commit-queue-
Updated patch none

Bear Travis
Reported 2014-07-29 14:52:23 PDT
document.fontloader has been renamed to document.fonts in the FontFaceSource interface.
Attachments
Initial Patch (19.65 KB, patch)
2014-07-29 15:35 PDT, Bear Travis 		bjonesbe: review+
bjonesbe: commit-queue-
DetailsFormatted DiffDiff
Updated patch (19.21 KB, patch)
2014-07-31 14:04 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2014-07-29 15:35:49 PDT
Created attachment 235701 [details] Initial Patch
Bem Jones-Bey
Comment 2 2014-07-30 14:04:12 PDT
Comment on attachment 235701 [details] Initial Patch r=me Please add an update to LayoutTests/http/tests/webfont/fontloader-loading-attribute.html before landing. Also nit: fontloader-multiple-families.html still says 'Test load events for fontloader.loadFont() with multiple font families.', it seems that should be fonts.loadFont() now.
Bear Travis
Comment 3 2014-07-31 14:04:04 PDT
Created attachment 235841 [details] Updated patch Updating http test and merging with the changes from bug 135420.
WebKit Commit Bot
Comment 4 2014-07-31 14:38:46 PDT
Comment on attachment 235841 [details] Updated patch Clearing flags on attachment: 235841 Committed r171886: <http://trac.webkit.org/changeset/171886>
WebKit Commit Bot
Comment 5 2014-07-31 14:38:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.