Bug 134090

Summary: [ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133229    
Attachments:
Description Flags
work in progress
none
the patch oliver: review+

Filip Pizlo
Reported 2014-06-19 21:35:08 PDT
Patch forthcoming.
Attachments
work in progress (32.33 KB, patch)
2014-06-19 21:36 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (58.78 KB, patch)
2014-06-21 12:56 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-06-19 21:36:39 PDT
Created attachment 233404 [details] work in progress
Filip Pizlo
Comment 2 2014-06-21 12:56:10 PDT
Created attachment 233542 [details] the patch
Filip Pizlo
Comment 3 2014-06-21 12:56:57 PDT
Comment on attachment 233542 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=233542&action=review > Source/JavaScriptCore/ChangeLog:111 > + Reviewed by NOBODY (OOPS!). > + > + Work in progress. > + > + * bytecode/GetByIdStatus.cpp: > + (JSC::GetByIdStatus::computeForStubInfo): > + (JSC::GetByIdStatus::computeFor): > + * bytecode/GetByIdStatus.h: > + * bytecode/PutByIdStatus.cpp: > + (JSC::PutByIdStatus::computeFor): > + * bytecode/PutByIdStatus.h: > + * bytecode/PutByIdVariant.h: > + (JSC::PutByIdVariant::constantChecks): > + * dfg/DFGAbstractInterpreterInlines.h: > + (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): > + * dfg/DFGByteCodeParser.cpp: > + (JSC::DFG::ByteCodeParser::parseBlock): > + * dfg/DFGConstantFoldingPhase.cpp: > + (JSC::DFG::ConstantFoldingPhase::foldConstants): > + (JSC::DFG::ConstantFoldingPhase::emitPutByOffset): > + (JSC::DFG::ConstantFoldingPhase::addChecks): > + * dfg/DFGNode.h: > + (JSC::DFG::Node::convertToMultiGetByOffset): > + (JSC::DFG::Node::convertToMultiPutByOffset): > + * dfg/DFGStructureAbstractValue.h: > + (JSC::DFG::StructureAbstractValue::set): > + > +2014-06-19 Filip Pizlo <fpizlo@apple.com> > + I've reverted this locally.
Oliver Hunt
Comment 4 2014-06-22 17:40:00 PDT
(Sorry that took so long I just wanted to checkout the branch and try to get a more complete understanding of what's going on. Kind of lost track over the last week)
Filip Pizlo
Comment 5 2014-06-22 18:09:01 PDT
Landed in http://trac.webkit.org/changeset/170275
Note You need to log in before you can comment on or make changes to this bug.