Bug 129819

Summary: Let the user define the full address of the performance-site-server for uploading results
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch
rniwa: review-, rniwa: commit-queue-
Patch none

Zoltan Horvath
Reported 2014-03-06 13:00:08 PST
Currently perftestsrunner.py assumes that the server uses https protocol all the time. That can be confusing. It's more straightforward, if you need to define explicitly the server's full address along with the protocol, when using this parameter. This patch updates the behavior and the affected unit tests.
Attachments
Patch (4.83 KB, patch)
2014-03-06 13:02 PST, Zoltan Horvath 		rniwa: review-
rniwa: commit-queue-
DetailsFormatted DiffDiff
Patch (5.24 KB, patch)
2014-03-06 14:04 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2014-03-06 13:02:31 PST
Created attachment 226029 [details] Patch
Ryosuke Niwa
Comment 2 2014-03-06 13:26:29 PST
Comment on attachment 226029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226029&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:312 > def _upload_json(self, test_results_server, json_path, host_path="/api/report", file_uploader=FileUploader): > - url = "https://%s%s" % (test_results_server, host_path) > + url = test_results_server + host_path This would break bots on build.webkit.org. We need to support both inputs during the transition. r- because of that.
Zoltan Horvath
Comment 3 2014-03-06 14:04:06 PST
Created attachment 226036 [details] Patch Added HTTPS as default protocol.
WebKit Commit Bot
Comment 4 2014-03-10 16:16:14 PDT
Comment on attachment 226036 [details] Patch Clearing flags on attachment: 226036 Committed r165413: <http://trac.webkit.org/changeset/165413>
WebKit Commit Bot
Comment 5 2014-03-10 16:16:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.