Bug 127990

Summary: [CSS Grid Layout] Rename named areas property
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jfernandez, kling, macpherson, menard, rakuco, rego, sergio, svillar, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127987    
Attachments:
Description Flags
Patch
none
Patch rebased and added suggested changes.
none
Patch
none
Patch
none
Patch rebased. none

Javier Fernandez
Reported 2014-01-31 02:50:30 PST
The property has been renamed from grid-template to grid-template-areas in the last two versions of the spec.
Attachments
Patch (51.81 KB, patch)
2014-02-06 16:22 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch rebased and added suggested changes. (52.17 KB, patch)
2014-02-07 06:53 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (52.60 KB, patch)
2014-02-10 12:37 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (52.55 KB, patch)
2014-02-13 06:04 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch rebased. (52.40 KB, patch)
2014-02-13 09:19 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2014-02-06 16:22:23 PST
Created attachment 223401 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-06 16:23:25 PST
Attachment 223401 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.cpp:5138: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sergio Villar Senin
Comment 3 2014-02-07 01:20:21 PST
Comment on attachment 223401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223401&action=review Looks good, added some nits. > Source/WebCore/css/CSSGridTemplateAreasValue.cpp:3 > + * Copyright (C) 2013 Igalia S.L. You might want to add 2014 here > Source/WebCore/css/CSSGridTemplateAreasValue.h:3 > + * Copyright (C) 2013 Igalia S.L. ditto. > LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html:12 > "thirdArea thirdArea"; Add spaces here to align both strings > LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html:12 > "thirdArea thirdArea"; ditto. > LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html:16 > + -webkit-grid-template-areas: "first second third" ditto > LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html:22 > "fourth fourth third"; ditto.
Javier Fernandez
Comment 4 2014-02-07 06:53:37 PST
Created attachment 223453 [details] Patch rebased and added suggested changes.
WebKit Commit Bot
Comment 5 2014-02-07 06:56:33 PST
Attachment 223453 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.cpp:5138: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Javier Fernandez
Comment 6 2014-02-10 02:54:15 PST
(In reply to comment #5) > Attachment 223453 [details] did not pass style-queue: > > > ERROR: Source/WebCore/css/CSSParser.cpp:5138: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] > Total errors found: 1 in 26 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. It's a bug in the check-webkit-style. I think the root cause is the ifdef clause immediately above, but still not able to reproduce it with a simpler case.
Javier Fernandez
Comment 7 2014-02-10 12:37:25 PST
Created attachment 223734 [details] Patch
WebKit Commit Bot
Comment 8 2014-02-10 12:39:45 PST
Attachment 223734 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.cpp:5133: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sergio Villar Senin
Comment 9 2014-02-13 05:10:24 PST
Comment on attachment 223734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223734&action=review Thanks for keeping this up to date ! > Source/WebCore/css/CSSGridTemplateAreasValue.cpp:4 > + * Copyright (C) 2014 Igalia S.L. Use a single line for these two, something like Copyright (C) 2013, 2014 Igalia S.L.
Javier Fernandez
Comment 10 2014-02-13 06:04:32 PST
Created attachment 224063 [details] Patch
WebKit Commit Bot
Comment 11 2014-02-13 07:56:26 PST
Comment on attachment 224063 [details] Patch Rejecting attachment 224063 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 224063, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: s-grid-layout/grid-item-end-after-get-set.html patching file LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html patching file LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html patching file LayoutTests/fast/css-grid-layout/grid-template-get-set-expected.txt patching file LayoutTests/fast/css-grid-layout/grid-template-get-set.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4816108091604992
Javier Fernandez
Comment 12 2014-02-13 09:19:37 PST
Created attachment 224077 [details] Patch rebased.
WebKit Commit Bot
Comment 13 2014-02-13 09:22:24 PST
Attachment 224077 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.cpp:5133: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sergio Villar Senin
Comment 14 2014-02-13 09:29:59 PST
(In reply to comment #13) > Attachment 224077 [details] did not pass style-queue: > > > ERROR: Source/WebCore/css/CSSParser.cpp:5133: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] > Total errors found: 1 in 26 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. BTW file a bug for this issue please.
WebKit Commit Bot
Comment 15 2014-02-13 10:02:00 PST
Comment on attachment 224077 [details] Patch rebased. Clearing flags on attachment: 224077 Committed r164035: <http://trac.webkit.org/changeset/164035>
WebKit Commit Bot
Comment 16 2014-02-13 10:02:05 PST
All reviewed patches have been landed. Closing bug.
Javier Fernandez
Comment 17 2014-02-13 11:34:02 PST
(In reply to comment #14) > (In reply to comment #13) > > Attachment 224077 [details] [details] did not pass style-queue: > > > > > > ERROR: Source/WebCore/css/CSSParser.cpp:5133: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] > > Total errors found: 1 in 26 files > > > > > > If any of these errors are false positives, please file a bug against check-webkit-style. > > BTW file a bug for this issue please. See bug #128751for details.
Note You need to log in before you can comment on or make changes to this bug.