Bug 127984

Summary: [clip-path] Implement support for margin-box as reference box and box shape
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, krit, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126207    
Attachments:
Description Flags
test-case
none
test-case-expected
none
Patch
none
Archive of layout-test-results from ews202 for win-future
none
Patch for landing none

Bem Jones-Bey
Reported 2014-01-30 22:16:53 PST
Right now the code uses the bounding client rect. It should use the actual margin-box. Note that tests will need to be added and changed as part of this fix.
Attachments
test-case (444 bytes, text/html)
2014-05-07 21:49 PDT, Zoltan Horvath 		no flags
Details
test-case-expected (209 bytes, text/html)
2014-05-07 21:49 PDT, Zoltan Horvath 		no flags
Details
Patch (19.18 KB, patch)
2018-07-15 03:21 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.79 MB, application/zip)
2018-07-15 06:09 PDT, EWS Watchlist 		no flags
Details
Patch for landing (19.18 KB, patch)
2018-07-17 08:41 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2014-05-07 21:49:03 PDT
Created attachment 231044 [details] test-case
Zoltan Horvath
Comment 2 2014-05-07 21:49:20 PDT
Created attachment 231045 [details] test-case-expected
Dirk Schulze
Comment 3 2018-07-14 21:37:34 PDT
Note: expectation file lacks the clipping to the background area. The dimensions are correct though.
Dirk Schulze
Comment 4 2018-07-15 03:21:36 PDT
Created attachment 345053 [details] Patch
EWS Watchlist
Comment 5 2018-07-15 06:09:45 PDT
Comment on attachment 345053 [details] Patch Attachment 345053 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8543016 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 6 2018-07-15 06:09:56 PDT
Created attachment 345054 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Dirk Schulze
Comment 7 2018-07-17 08:41:44 PDT
Created attachment 345154 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-07-17 09:52:11 PDT
Comment on attachment 345154 [details] Patch for landing Clearing flags on attachment: 345154 Committed r233886: <https://trac.webkit.org/changeset/233886>
WebKit Commit Bot
Comment 9 2018-07-17 09:52:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-07-17 09:56:49 PDT
<rdar://problem/42289187>
Note You need to log in before you can comment on or make changes to this bug.