Bug 126892

Summary:

Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when line position has CSS px fractions.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, WebkitBugTracker

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

126283

Attachments:

Description	Flags
test case	none
Patch	none
Patch	none

alan

Reported 2014-01-13 07:26:39 PST

fast/forms/textAreaLineHeight-simple-lines.html

Attachments
test case (327 bytes, text/html) 2014-01-14 14:52 PST, alan	no flags	Details
Patch (369.49 KB, patch) 2014-01-17 21:17 PST, alan	no flags	Details Formatted Diff Diff
Patch (369.56 KB, patch) 2014-01-17 21:21 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2014-01-14 14:36:59 PST

SimpleLineLayout's paintFlow() needs to call roundedIntPoint() on paint offset to match InlineTextBox's paint positioning. something along these lines: --- a/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp +++ b/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp @@ -80,9 +80,10 @@ void paintFlow(const RenderBlockFlow& flow, const Layout& layout, PaintInfo& pai GraphicsContextStateSaver stateSaver(context, textPaintStyle.strokeWidth > 0); updateGraphicsContext(context, textPaintStyle); + LayoutPoint adjustedPaintOffset = roundedIntPoint(paintOffset); LayoutRect paintRect = paintInfo.rect; - paintRect.moveBy(-paintOffset); + paintRect.moveBy(-adjustedPaintOffset); auto resolver = runResolver(flow, layout); auto range = resolver.rangeForRect(paintRect); @@ -92,9 +93,9 @@ void paintFlow(const RenderBlockFlow& flow, const Layout& layout, PaintInfo& pai continue; TextRun textRun(run.text()); textRun.setTabSize(!style.collapseWhiteSpace(), style.tabSize()); - context.drawText(font, textRun, run.baseline() + paintOffset); + context.drawText(font, textRun, run.baseline() + adjustedPaintOffset); if (debugBordersEnabled) - paintDebugBorders(context, run.rect(), paintOffset); + paintDebugBorders(context, run.rect(), adjustedPaintOffset); } }

alan

Comment 2 2014-01-14 14:52:41 PST

Created attachment 221206 [details] test case

alan

Comment 3 2014-01-14 16:49:23 PST

*** Bug 126893 has been marked as a duplicate of this bug. ***

alan

Comment 4 2014-01-14 20:47:38 PST

*** Bug 126894 has been marked as a duplicate of this bug. ***

alan

Comment 5 2014-01-14 20:49:22 PST

additional failed cases (from dupes) LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse-padding.html LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse.html LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html LayoutTests/fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html LayoutTests/fast/regions/overflow-moving-below-floats-in-variable-width-regions.html LayoutTests/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html LayoutTests/fast/regions/overflow-size-change-in-variable-width-regions.html LayoutTests/fast/regions/overflow-size-change-with-stacking-context.html LayoutTests/fast/regions/selection/selecting-text-through-different-region-flows.html

alan

Comment 6 2014-01-15 09:11:54 PST

actually fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html doesnt get fixed by this. For that, webkit.org/b/124784 needs revisiting.

alan

Comment 7 2014-01-16 08:57:24 PST

*** Bug 126891 has been marked as a duplicate of this bug. ***

alan

Comment 8 2014-01-16 08:58:03 PST

fast/css/word-spacing-between-blocks.html fast/css/word-spacing-between-inlines.html

alan

Comment 9 2014-01-17 21:17:01 PST

Created attachment 221530 [details] Patch