Bug 125224

Summary: [CSS Shapes] Shape images are now <image> types, not just URIs
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, bdakin, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, hyatt, jonlee, kling, kondapallykalyan, macpherson, menard, sam, simon.fraser, syoichi, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124173    
Attachments:
Description Flags
Patch
none
Patch
kling: review+
Patch none

Hans Muller
Reported 2013-12-04 08:08:13 PST
The Shapes specification now defines shape-inside and shape-outside image values as <image> types, instead of just URIs. See: http://dev.w3.org/csswg/css-shapes/#shapes-from-image http://dev.w3.org/csswg/css-images-3/#image-types
Attachments
Patch (14.76 KB, patch)
2013-12-05 12:25 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Patch (14.80 KB, patch)
2014-01-07 16:16 PST, Hans Muller 		kling: review+
DetailsFormatted DiffDiff
Patch (16.79 KB, patch)
2014-01-14 09:41 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-12-05 12:25:23 PST
Created attachment 218532 [details] Patch Added support for image-set valued shapes. Added an optional ResourceLoaderOptions parameter to CSSImageSetValue::cachedImageSet() to enable CORS-enabled fetch of images. This change is based on a similar patch for ordinary shape image values: https://bugs.webkit.org/show_bug.cgi?id=123114.
Andreas Kling
Comment 2 2013-12-19 09:41:54 PST
I'm not really sure who's the best person to review this patch. CC'ing a couple of candidates.
Hans Muller
Comment 3 2014-01-07 16:16:22 PST
Created attachment 220566 [details] Patch Resync'd with trunk.
Andreas Kling
Comment 4 2014-01-13 23:47:44 PST
Comment on attachment 220566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220566&action=review r=me > LayoutTests/fast/shapes/shape-outside-floats/shape-outside-image-set.html:7 > + /* The shape-outisde image's width is smaller than the float's width (120 < 150) to make it Typo, shape-outside. > Source/WebCore/rendering/shapes/Shape.cpp:256 > - ASSERT(styleImage && styleImage->isCachedImage() && styleImage->cachedImage() && styleImage->cachedImage()->image()); > + ASSERT(styleImage && styleImage->cachedImage() && styleImage->cachedImage()->hasImage()); These should be broken into separate assertions so you can immediately tell what went wrong. It'd also be nicer if 'styleImage' were a reference, since we don't support it being null.
Hans Muller
Comment 5 2014-01-14 09:41:11 PST
Created attachment 221171 [details] Patch Made the suggested changes.
WebKit Commit Bot
Comment 6 2014-01-14 10:12:34 PST
Comment on attachment 221171 [details] Patch Clearing flags on attachment: 221171 Committed r161980: <http://trac.webkit.org/changeset/161980>
WebKit Commit Bot
Comment 7 2014-01-14 10:12:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.