Bug 122590

Summary: Move inheritance of PopupMenuClient from RenderSearchField to RenderTextControlSingleLine
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: FormsAssignee: ChangSeok Oh <changseok>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, buildbot, gustavo, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98934    
Attachments:
Description Flags
Patch
none
Patch none

ChangSeok Oh
Reported 2013-10-10 01:13:16 PDT
Not only search field but also other single line text fields(text, email etc) could have a popup menu to suggest previous input or show predefined options like datalist. So I think it would be better that RenderTextControlSingleLine inherits PopupMenuClient than RenderSearchField. This bug just changes the inheritance status, but eventually I'm going to fill the inherited methods of RenderTextControlSingleLine with code related with datalist. You can see a rough sketch here. http://cgit.collabora.com/git/user/kevino/WebKit.git/commit/?h=datalist&id=8a931ede66872520559af1f0564cbfa0633fbb14
Attachments
Patch (9.82 KB, patch)
2013-10-11 00:08 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (9.69 KB, patch)
2013-10-11 01:26 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-10-11 00:08:07 PDT
Created attachment 213973 [details] Patch
Build Bot
Comment 2 2013-10-11 00:13:15 PDT
Comment on attachment 213973 [details] Patch Attachment 213973 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3953033
Build Bot
Comment 3 2013-10-11 00:34:45 PDT
Comment on attachment 213973 [details] Patch Attachment 213973 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3946029
ChangSeok Oh
Comment 4 2013-10-11 01:26:10 PDT
Created attachment 213976 [details] Patch
Gustavo Noronha (kov)
Comment 5 2013-10-16 01:32:14 PDT
Comment on attachment 213976 [details] Patch I don't feel qualified to judge whether this change makes sense on its merits, but I think it would be better to have the patch be the actual functional change instead of just the ground work.
ChangSeok Oh
Comment 6 2014-01-10 09:02:16 PST
The approach is changed not to use GtkPopup
Note You need to log in before you can comment on or make changes to this bug.