Bug 121616

Summary:

[CSS Shapes] Support block content with inline content around floats in shape-inside

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bjonesbe, commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

102846

Bug Blocks:

121615

Attachments:

Description	Flags
proposed patch	none
proposed patch	none
proposed patch	none

Zoltan Horvath

Reported 2013-09-19 09:56:57 PDT

Support block content with inline content around floats in shape-inside, look at bug #102846.

Attachments
proposed patch (30.66 KB, patch) 2013-10-01 16:57 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
proposed patch (30.66 KB, patch) 2013-10-01 17:56 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
proposed patch (30.65 KB, patch) 2013-10-01 17:58 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2013-10-01 16:57:33 PDT

Created attachment 213132 [details] proposed patch

Zoltan Horvath

Comment 2 2013-10-01 17:56:59 PDT

Created attachment 213138 [details] proposed patch

Zoltan Horvath

Comment 3 2013-10-01 17:58:12 PDT

Created attachment 213139 [details] proposed patch

Dave Hyatt

Comment 4 2013-10-03 10:47:03 PDT

Comment on attachment 213139 [details] proposed patch r=me

WebKit Commit Bot

Comment 5 2013-10-03 11:23:37 PDT

Comment on attachment 213139 [details] proposed patch Clearing flags on attachment: 213139 Committed r156846: <http://trac.webkit.org/changeset/156846>

WebKit Commit Bot

Comment 6 2013-10-03 11:23:38 PDT

All reviewed patches have been landed. Closing bug.

Bem Jones-Bey

Comment 7 2013-10-08 09:54:55 PDT

Comment on attachment 213139 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=213139&action=review > Source/WebCore/rendering/RenderBlock.cpp:3371 > + LayoutSize floatLogicalSize = LayoutSize(childBox->logicalWidth(), childBox->logicalHeight()); I just came across this in the code, and it looks completely wrong to me. The floatingObject's dimensions are those of the margin box, and the logicalWidth and Height of the childBox are those of the content box. Floats are supposed to be positioned based on their margins, so this looks like it wouldn't work properly in the case of a float with margins. Am I missing something?

Bem Jones-Bey

Comment 8 2013-10-08 10:30:18 PDT

(In reply to comment #7) > (From update of attachment 213139 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213139&action=review > > > Source/WebCore/rendering/RenderBlock.cpp:3371 > > + LayoutSize floatLogicalSize = LayoutSize(childBox->logicalWidth(), childBox->logicalHeight()); > > I just came across this in the code, and it looks completely wrong to me. The floatingObject's dimensions are those of the margin box, and the logicalWidth and Height of the childBox are those of the content box. Floats are supposed to be positioned based on their margins, so this looks like it wouldn't work properly in the case of a float with margins. Am I missing something? By content box, I mean border box, but same point. :-)

Note You need to log in before you can comment on or make changes to this bug.