Bug 118051

Summary: [CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, commit-queue, dino, esprehn+autocc, glenn, hyatt, jchaffraix, kling, koivisto, macpherson, menard, svillar, syoichi, tony
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103314, 119756    
Attachments:
Description Flags
Patch kling: review+

Sergio Villar Senin
Reported 2013-06-26 01:41:37 PDT
We should consider merging: Add support for parsing <grid-line> that includes a 'span' This adds the parsing, style resolution and getComputedStyle bits to our code. The rendering code was not made aware of the new type of GridPosition yet. BUG=229713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148766
Attachments
Patch (47.04 KB, patch)
2013-06-26 03:53 PDT, Sergio Villar Senin 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-06-26 03:53:06 PDT
Created attachment 205467 [details] Patch
Andreas Kling
Comment 2 2013-08-06 00:41:25 PDT
Comment on attachment 205467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205467&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1109 > + return list; return list.release(); would be slightly more efficient.
Sergio Villar Senin
Comment 3 2013-08-06 04:44:51 PDT
Committed r153748: <http://trac.webkit.org/changeset/153748>
Note You need to log in before you can comment on or make changes to this bug.