Bug 116059

Summary: [css exclusions] fast/css/variables/var-inside-shape.html is failing
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, commit-queue, csaavedra, gyuyoung.kim, kling, koivisto, mrowe, rakuco, svillar, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115919    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Bear Travis
Reported 2013-05-13 14:08:52 PDT
Toggling CSS Exclusions on by default has caused the test to fail.
Attachments
Patch (5.83 KB, patch)
2013-05-17 02:14 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-05-13 15:35:38 PDT
CSS Variables are not working with shape-inside. This was not diagnosed until Exclusions were toggled on by default in 115919, as the test expectation does not enable shape-inside. The expectation ignored the non-variable shape-insides. The test case did not correctly resolve the variable shape-insides.
Sergio Villar Senin
Comment 2 2013-05-16 10:08:57 PDT
Working on this. Patch to follow.
Sergio Villar Senin
Comment 3 2013-05-17 02:14:04 PDT
Created attachment 202051 [details] Patch
Alexandru Chiculita
Comment 4 2013-06-12 09:56:00 PDT
Comment on attachment 202051 [details] Patch Looks good.
Sergio Villar Senin
Comment 5 2013-06-12 10:01:31 PDT
Comment on attachment 202051 [details] Patch Clearing flags on attachment: 202051 Committed r151506: <http://trac.webkit.org/changeset/151506>
Sergio Villar Senin
Comment 6 2013-06-12 10:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.